Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3152)

Unified Diff: chrome/installer/mini_installer.gyp

Issue 7977003: Relanding precompiled header support for VS 2008, now enabled for (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix comments per review comments. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/win_precompile.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/mini_installer.gyp
diff --git a/chrome/installer/mini_installer.gyp b/chrome/installer/mini_installer.gyp
index 6c41bd39eebf85835a652aa3028e85e05ab77d8b..18b39f820498041ec72826cee2a885179418cc1e 100644
--- a/chrome/installer/mini_installer.gyp
+++ b/chrome/installer/mini_installer.gyp
@@ -175,6 +175,21 @@
{
'target_name': 'mini_installer',
'type': 'executable',
+ 'configurations': {
+ 'Debug': {
+ # Disable precompiled headers for this project, to avoid
+ # linker errors when building with VS 2008.
+ #
+ # Note that putting this in the 'target_defaults'
+ # section earlier in the file does not successfully
+ # override the 'target_defaults' brought in by the
+ # build/win_precompile.gypi file, so the overriding
+ # needs to be done here, directly in the mini_installer
+ # target.
+ 'msvs_precompiled_header': '',
+ 'msvs_precompiled_source': '',
+ },
+ },
'sources': [
'mini_installer/chrome.release',
'mini_installer/chrome_appid.cc',
« no previous file with comments | « build/win_precompile.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698