Relanding precompiled header support for VS 2008, now enabled for

chrome/installer/mini_installer.gyp

 {
   'variables': {
     'version_py': '../../chrome/tools/build/version.py',
     'version_path': '../../chrome/VERSION',
     'lastchange_path': '<(SHARED_INTERMEDIATE_DIR)/build/LASTCHANGE',
     # 'branding_dir' is set in the 'conditions' section at the bottom.
     'msvs_use_common_release': 0,
     'msvs_use_common_linker_extras': 0,
   },
   'includes': [
@@ skipping 157 matching lines @@
             'variables': {
                'branding_dir': '../app/theme/chromium',
             },
           }],
         ],
       },
       'targets': [
         {
           'target_name': 'mini_installer',
           'type': 'executable',
+          'configurations': {
+            'Debug': {
+              # Disable precompiled headers for this project, to avoid
+              # linker errors when building with VS 2008.
+              #
+              # Note that putting this in the 'target_defaults'
+              # section earlier in the file does not successfully
+              # override the 'target_defaults' brought in by the
+              # build/win_precompile.gypi file, so the overriding
+              # needs to be done here, directly in the mini_installer
+              # target.
+              'msvs_precompiled_header': '',
+              'msvs_precompiled_source': '',
+            },
+          },
           'sources': [
             'mini_installer/chrome.release',
             'mini_installer/chrome_appid.cc',
           ],
           'rules': [
             {
               'rule_name': 'installer_archive',
               'extension': 'release',
               'variables': {
                 'create_installer_archive_py_path':
@@ skipping 13 matching lines @@
               'outputs': [
                 'xxx.out',
                 '<(PRODUCT_DIR)/<(RULE_INPUT_NAME).7z',
                 '<(PRODUCT_DIR)/<(RULE_INPUT_NAME).packed.7z',
                 '<(PRODUCT_DIR)/setup.ex_',
                 '<(PRODUCT_DIR)/packed_files.txt',
               ],
               'action': [
                 'python',
                 '<(create_installer_archive_py_path)',
+

[jeanluc1, 2011/09/20 16:54:25]

Extra line on purpose?

[Jói, 2011/09/20 21:44:06]

No, fixed.

                 '--output_dir=<(PRODUCT_DIR)',
                 '--input_file=<(RULE_INPUT_PATH)',
                 # TODO(sgk):  may just use environment variables
                 #'--distribution=$(CHROMIUM_BUILD)',
                 '--distribution=_google_chrome',
                 # Optional arguments to generate diff installer
                 #'--last_chrome_installer=C:/Temp/base',
                 #'--setup_exe_format=DIFF',
                 #'--diff_algorithm=COURGETTE',
               ],
               'message': 'Create installer archive'
             },
           ],
         },
       ],
     }],
     [ 'branding == "Chrome"', {
       'variables': {
          'branding_dir': '../app/theme/google_chrome',
       },
     }, { # else branding!="Chrome"
       'variables': {
          'branding_dir': '../app/theme/chromium',
       },
     }],
   ],
 }