Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: build/win_precompile.gypi

Issue 7977003: Relanding precompiled header support for VS 2008, now enabled for (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix comments per review comments. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/time_win.cc ('k') | chrome/installer/mini_installer.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/win_precompile.gypi
diff --git a/build/win_precompile.gypi b/build/win_precompile.gypi
index 90bcdff615b3e9e25e6dc1a42e00f9dc260b525b..592e59f2219c132b1567852d276e1d3a7d841363 100644
--- a/build/win_precompile.gypi
+++ b/build/win_precompile.gypi
@@ -3,18 +3,26 @@
# found in the LICENSE file.
# Include this file to make targets in your .gyp use the default
-# precompiled header on Windows.
+# precompiled header on Windows, in debug builds only as the official
+# builders blow up (out of memory) if precompiled headers are used for
+# release builds.
{
'conditions': [
- # Restricted to VS 2010 until GYP also supports suppressing
- # precompiled headers on .c files in VS 2008.
- ['OS=="win" and (MSVS_VERSION=="2010" or MSVS_VERSION=="2010e")', {
- 'target_defaults': {
- 'msvs_precompiled_header': '<(DEPTH)/build/precompile.h',
- 'msvs_precompiled_source': '<(DEPTH)/build/precompile.cc',
- 'sources': ['<(DEPTH)/build/precompile.cc'],
- },
- }],
+ ['OS=="win"', {
+ 'target_defaults': {
+ 'configurations': {
+ 'Debug': {
+ 'msvs_precompiled_header': '<(DEPTH)/build/precompile.h',
+ 'msvs_precompiled_source': '<(DEPTH)/build/precompile.cc',
+ },
+ },
+
+ # Sources can't be specified inside the 'Debug'
+ # configuration. Since precompile.cc only contains
+ # comments, it won't have any effect for 'Release' builds.
+ 'sources': ['<(DEPTH)/build/precompile.cc'],
+ }
+ }],
],
}
« no previous file with comments | « base/time_win.cc ('k') | chrome/installer/mini_installer.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698