Issue 7972018: Don't depend on the embedder creating a plugin. That way embedders can always provide an empty Co...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7972018: Don't depend on the embedder creating a plugin. That way embedders can always provide an empty Co... (Closed)

Created:
9 years, 3 months ago by jam

Modified:
9 years, 3 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke+watch-content_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Don't depend on the embedder creating a plugin. That way embedders can always provide an empty ContentRendererClient interface and still have functional rendering. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102427

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -31 lines)			Patch
M	chrome/renderer/chrome_content_renderer_client.h	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/renderer/chrome_content_renderer_client.cc	View		1 chunk	+8 lines, -11 lines	0 comments	Download
M	content/renderer/content_renderer_client.h	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	content/renderer/mock_content_renderer_client.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/renderer/mock_content_renderer_client.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	content/renderer/render_view.cc	View		1 chunk	+7 lines, -2 lines	0 comments	Download
M	content/shell/shell_content_renderer_client.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/shell/shell_content_renderer_client.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

wfm lgtm