content/shell/shell_content_renderer_client.cc - Issue 7972018: Don't depend on the embedder creating a plugin. That way embedders can always provide an empty Co...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/shell_content_renderer_client.cc

Issue 7972018: Don't depend on the embedder creating a plugin. That way embedders can always provide an empty Co... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/shell_content_renderer_client.cc

===================================================================

--- content/shell/shell_content_renderer_client.cc (revision 102285)

+++ content/shell/shell_content_renderer_client.cc (working copy)

@@ -4,7 +4,6 @@

#include "content/shell/shell_content_renderer_client.h"

-#include "content/renderer/render_view.h"

#include "v8/include/v8.h"

namespace content {

@@ -29,11 +28,12 @@

return std::string();

}

-WebKit::WebPlugin* ShellContentRendererClient::CreatePlugin(

+bool ShellContentRendererClient::OverrideCreatePlugin(

RenderView* render_view,

WebKit::WebFrame* frame,

- const WebKit::WebPluginParams& params) {

- return render_view->CreatePluginNoCheck(frame, params);

+ const WebKit::WebPluginParams& params,

+ WebKit::WebPlugin** plugin) {

+ return false;

}

void ShellContentRendererClient::ShowErrorPage(RenderView* render_view,

« no previous file with comments | « content/shell/shell_content_renderer_client.h ('k') | no next file » | no next file with comments »