chrome/renderer/chrome_content_renderer_client.h - Issue 7972018: Don't depend on the embedder creating a plugin. That way embedders can always provide an empty Co...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_content_renderer_client.h

Issue 7972018: Don't depend on the embedder creating a plugin. That way embedders can always provide an empty Co... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/chrome_content_renderer_client.h

===================================================================

--- chrome/renderer/chrome_content_renderer_client.h (revision 102285)

+++ chrome/renderer/chrome_content_renderer_client.h (working copy)

@@ -42,10 +42,11 @@

virtual void SetNumberOfViews(int number_of_views) OVERRIDE;

virtual SkBitmap* GetSadPluginBitmap() OVERRIDE;

virtual std::string GetDefaultEncoding() OVERRIDE;

- virtual WebKit::WebPlugin* CreatePlugin(

+ virtual bool OverrideCreatePlugin(

RenderView* render_view,

WebKit::WebFrame* frame,

- const WebKit::WebPluginParams& params) OVERRIDE;

+ const WebKit::WebPluginParams& params,

+ WebKit::WebPlugin** plugin) OVERRIDE;

virtual void ShowErrorPage(RenderView* render_view,

WebKit::WebFrame* frame,

int http_status_code) OVERRIDE;

@@ -93,7 +94,7 @@

void OnPurgeMemory();

private:

- WebKit::WebPlugin* CreatePluginImpl(

+ WebKit::WebPlugin* CreatePlugin(

RenderView* render_view,

WebKit::WebFrame* frame,

const WebKit::WebPluginParams& params,

« no previous file with comments | « no previous file | chrome/renderer/chrome_content_renderer_client.cc » ('j') | no next file with comments »