Don't depend on the embedder creating a plugin. That way embedders can always provide an empty Co...

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/message_loop.h"
@@ skipping 247 matching lines @@
 }
 
 SkBitmap* ChromeContentRendererClient::GetSadPluginBitmap() {
   return ResourceBundle::GetSharedInstance().GetBitmapNamed(IDR_SAD_PLUGIN);
 }
 
 std::string ChromeContentRendererClient::GetDefaultEncoding() {
   return l10n_util::GetStringUTF8(IDS_DEFAULT_ENCODING);
 }
 
+bool ChromeContentRendererClient::OverrideCreatePlugin(
+      RenderView* render_view,
+      WebFrame* frame,
+      const WebPluginParams& params,
+      WebKit::WebPlugin** plugin) {
+  bool is_default_plugin;
+  *plugin = CreatePlugin(render_view, frame, params, &is_default_plugin);
+  if (!*plugin || is_default_plugin)
+    MissingPluginReporter::GetInstance()->ReportPluginMissing(
+        params.mimeType.utf8(), params.url);
+  return true;
+}
+
 WebPlugin* ChromeContentRendererClient::CreatePlugin(
       RenderView* render_view,
       WebFrame* frame,
-      const WebPluginParams& original_params) {
-  bool is_default_plugin;
-  WebPlugin* plugin = CreatePluginImpl(render_view,
-                                       frame,
-                                       original_params,
-                                       &is_default_plugin);
-  if (!plugin || is_default_plugin)
-    MissingPluginReporter::GetInstance()->ReportPluginMissing(
-        original_params.mimeType.utf8(),
-        original_params.url);
-  return plugin;
-}
-
-WebPlugin* ChromeContentRendererClient::CreatePluginImpl(
-      RenderView* render_view,
-      WebFrame* frame,
       const WebPluginParams& original_params,
       bool* is_default_plugin) {
   *is_default_plugin = false;
   CommandLine* cmd = CommandLine::ForCurrentProcess();
   webkit::WebPluginInfo info;
   GURL url(original_params.url);
   std::string orig_mime_type = original_params.mimeType.utf8();
   std::string actual_mime_type;
 
   bool found = render_view->GetPluginInfo(
@@ skipping 464 matching lines @@
   if (spellcheck_.get())
     thread->RemoveObserver(spellcheck_.get());
   SpellCheck* new_spellcheck = new SpellCheck();
   if (spellcheck_provider_)
     spellcheck_provider_->SetSpellCheck(new_spellcheck);
   spellcheck_.reset(new_spellcheck);
   thread->AddObserver(new_spellcheck);
 }
 
 }  // namespace chrome