Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7918001: [Sync] Move ChangeRecord into its own file (change_record.{h,cc}) (Closed)

Created:
9 years, 3 months ago by akalin
Modified:
9 years, 3 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, GeorgeY, ncarter (slow), idana, Raghu Simha, Paweł Hajdan Jr., Ilya Sherman, tim (not reviewing), dhollowa
Visibility:
Public.

Description

[Sync] Move ChangeRecord into its own file (change_record.{h,cc}) Define ChangeRecordList and ImmutableChangeRecordList. Pass those around instead of (ChangeRecord*, size) pairs. Remove unused OnMigrationNeededForTypes(). BUG=85658, 85481 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101619

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove obsolete override #

Patch Set 3 : sync to head #

Total comments: 6

Patch Set 4 : Address comments #

Total comments: 2

Patch Set 5 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+427 lines, -411 lines) Patch
M chrome/browser/sync/abstract_profile_sync_service_test.h View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/abstract_profile_sync_service_test.cc View 1 2 3 4 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/autofill_change_processor.h View 4 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/sync/glue/autofill_change_processor.cc View 10 chunks +22 lines, -21 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_change_processor.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_change_processor.cc View 4 chunks +17 lines, -11 lines 0 comments Download
M chrome/browser/sync/glue/change_processor.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/change_processor_mock.h View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/generic_change_processor.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/generic_change_processor.cc View 3 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/sync/glue/password_change_processor.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/password_change_processor.cc View 3 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/sync/glue/session_change_processor.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/session_change_processor.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/theme_change_processor.h View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/theme_change_processor.cc View 4 chunks +12 lines, -13 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_change_processor.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_change_processor.cc View 1 6 chunks +13 lines, -13 lines 0 comments Download
A chrome/browser/sync/internal_api/change_record.h View 1 chunk +67 lines, -0 lines 0 comments Download
A chrome/browser/sync/internal_api/change_record.cc View 1 chunk +82 lines, -0 lines 0 comments Download
M chrome/browser/sync/internal_api/change_reorder_buffer.h View 5 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/sync/internal_api/change_reorder_buffer.cc View 5 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/sync/internal_api/sync_manager.h View 1 4 chunks +6 lines, -49 lines 0 comments Download
M chrome/browser/sync/internal_api/sync_manager.cc View 1 4 chunks +5 lines, -74 lines 0 comments Download
M chrome/browser/sync/internal_api/syncapi_unittest.cc View 1 2 3 12 chunks +21 lines, -23 lines 0 comments Download
M chrome/browser/sync/js/js_sync_manager_observer.h View 1 2 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/sync/js/js_sync_manager_observer.cc View 1 4 chunks +5 lines, -15 lines 0 comments Download
M chrome/browser/sync/js/js_sync_manager_observer_unittest.cc View 1 4 chunks +10 lines, -29 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 8 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_preference_unittest.cc View 1 2 3 8 chunks +22 lines, -25 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_session_unittest.cc View 1 2 3 5 chunks +14 lines, -14 lines 0 comments Download
M chrome/chrome.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
akalin
+zea for review
9 years, 3 months ago (2011-09-15 22:45:22 UTC) #1
Nicolas Zea
http://codereview.chromium.org/7918001/diff/1/chrome/browser/sync/glue/theme_change_processor.cc File chrome/browser/sync/glue/theme_change_processor.cc (right): http://codereview.chromium.org/7918001/diff/1/chrome/browser/sync/glue/theme_change_processor.cc#newcode82 chrome/browser/sync/glue/theme_change_processor.cc:82: if (change_count > 1u) { != 1u? (given the ...
9 years, 3 months ago (2011-09-16 21:20:26 UTC) #2
akalin
All comments address, PTAL http://codereview.chromium.org/7918001/diff/1/chrome/browser/sync/glue/theme_change_processor.cc File chrome/browser/sync/glue/theme_change_processor.cc (right): http://codereview.chromium.org/7918001/diff/1/chrome/browser/sync/glue/theme_change_processor.cc#newcode82 chrome/browser/sync/glue/theme_change_processor.cc:82: if (change_count > 1u) { ...
9 years, 3 months ago (2011-09-16 21:50:36 UTC) #3
Nicolas Zea
lgtm http://codereview.chromium.org/7918001/diff/4035/chrome/browser/sync/abstract_profile_sync_service_test.cc File chrome/browser/sync/abstract_profile_sync_service_test.cc (right): http://codereview.chromium.org/7918001/diff/4035/chrome/browser/sync/abstract_profile_sync_service_test.cc#newcode72 chrome/browser/sync/abstract_profile_sync_service_test.cc:72: sync_api::ImmutableChangeRecordList Comment that this is static.
9 years, 3 months ago (2011-09-16 22:23:54 UTC) #4
akalin
9 years, 3 months ago (2011-09-16 22:56:03 UTC) #5 
Done, submitting

http://codereview.chromium.org/7918001/diff/4035/chrome/browser/sync/abstract...
File chrome/browser/sync/abstract_profile_sync_service_test.cc (right):

http://codereview.chromium.org/7918001/diff/4035/chrome/browser/sync/abstract...
chrome/browser/sync/abstract_profile_sync_service_test.cc:72:
sync_api::ImmutableChangeRecordList
On 2011/09/16 22:23:54, nzea wrote:
> Comment that this is static.

Done.

Powered by Google App Engine
This is Rietveld 408576698