[Sync] Move ChangeRecord into its own file (change_record.{h,cc})

chrome/browser/sync/glue/theme_change_processor.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/glue/theme_change_processor.h"
 
 #include "base/logging.h"
 #include "base/tracked.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/glue/theme_util.h"
+#include "chrome/browser/sync/internal_api/change_record.h"
 #include "chrome/browser/sync/internal_api/read_node.h"
-#include "chrome/browser/sync/internal_api/sync_manager.h"
 #include "chrome/browser/sync/internal_api/write_node.h"
 #include "chrome/browser/sync/internal_api/write_transaction.h"
 #include "chrome/browser/sync/protocol/theme_specifics.pb.h"
 #include "chrome/browser/sync/unrecoverable_error_handler.h"
 #include "chrome/browser/themes/theme_service_factory.h"
 #include "chrome/browser/themes/theme_service.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/extensions/extension.h"
 #include "content/common/notification_details.h"
 #include "content/common/notification_source.h"
@@ skipping 34 matching lines @@
   // Do a write only if something actually changed so as to guard
   // against cycles.
   if (!AreThemeSpecificsEqual(old_theme_specifics, new_theme_specifics)) {
     node.SetThemeSpecifics(new_theme_specifics);
   }
   return;
 }
 
 void ThemeChangeProcessor::ApplyChangesFromSyncModel(
     const sync_api::BaseTransaction* trans,
-    const sync_api::SyncManager::ChangeRecord* changes,
-    int change_count) {
+    const sync_api::ImmutableChangeRecordList& changes) {
   if (!running()) {
     return;
   }
   // TODO(akalin): Normally, we should only have a single change and
   // it should be an update.  However, the syncapi may occasionally
   // generates multiple changes.  When we fix syncapi to not do that,
   // we can remove the extra logic below.  See:
   // http://code.google.com/p/chromium/issues/detail?id=41696 .
-  if (change_count < 1) {
-    std::string err("Unexpected change_count: ");
-    err += change_count;
-    error_handler()->OnUnrecoverableError(FROM_HERE, err);
+  if (changes.Get().empty()) {
+    error_handler()->OnUnrecoverableError(FROM_HERE,
+                                          "Change list unexpectedly empty");
     return;
   }
-  if (change_count > 1) {
+  const size_t change_count = changes.Get().size();
+  if (change_count > 1u) {
     LOG(WARNING) << change_count << " theme changes detected; "
                  << "only applying the last one";
   }
-  const sync_api::SyncManager::ChangeRecord& change =
-      changes[change_count - 1];
-  if (change.action != sync_api::SyncManager::ChangeRecord::ACTION_UPDATE &&
-      change.action != sync_api::SyncManager::ChangeRecord::ACTION_DELETE) {
+  const sync_api::ChangeRecord& change =
+      changes.Get()[change_count - 1];
+  if (change.action != sync_api::ChangeRecord::ACTION_UPDATE &&
+      change.action != sync_api::ChangeRecord::ACTION_DELETE) {
     std::string err = "strange theme change.action " + change.action;
     error_handler()->OnUnrecoverableError(FROM_HERE, err);
     return;
   }
   sync_pb::ThemeSpecifics theme_specifics;
   // If the action is a delete, simply use the default values for
   // ThemeSpecifics, which would cause the default theme to be set.
-  if (change.action != sync_api::SyncManager::ChangeRecord::ACTION_DELETE) {
+  if (change.action != sync_api::ChangeRecord::ACTION_DELETE) {
     sync_api::ReadNode node(trans);
     if (!node.InitByIdLookup(change.id)) {
       error_handler()->OnUnrecoverableError(FROM_HERE,
                                             "Theme node lookup failed.");
       return;
     }
     DCHECK_EQ(node.GetModelType(), syncable::THEMES);
     DCHECK(profile_);
     theme_specifics = node.GetThemeSpecifics();
   }
@@ skipping 22 matching lines @@
           ThemeServiceFactory::GetForProfile(profile_)));
 }
 
 void ThemeChangeProcessor::StopObserving() {
   DCHECK(profile_);
   VLOG(1) << "Unobserving all notifications";
   notification_registrar_.RemoveAll();
 }
 
 }  // namespace browser_sync