[Sync] Move ChangeRecord into its own file (change_record.{h,cc})

chrome/browser/sync/internal_api/sync_manager.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_INTERNAL_API_SYNC_MANAGER_H_
 #define CHROME_BROWSER_SYNC_INTERNAL_API_SYNC_MANAGER_H_
 
 #include <string>
+#include <vector>
 
 #include "base/basictypes.h"
 #include "base/callback_old.h"
-#include "base/memory/linked_ptr.h"
+#include "chrome/browser/sync/internal_api/change_record.h"
 #include "chrome/browser/sync/internal_api/configure_reason.h"
-#include "chrome/browser/sync/protocol/password_specifics.pb.h"
 #include "chrome/browser/sync/protocol/sync_protocol_error.h"
 #include "chrome/browser/sync/syncable/model_type.h"
 #include "chrome/browser/sync/util/weak_handle.h"
 #include "chrome/common/net/gaia/google_service_auth_error.h"
 
 class FilePath;
 
 namespace base {
 class DictionaryValue;
 }  // namespace base
 
 namespace browser_sync {
 class JsBackend;
 class JsEventHandler;
 class ModelSafeWorkerRegistrar;
 
 namespace sessions {
 struct SyncSessionSnapshot;
 }  // namespace sessions
 }  // namespace browser_sync
 
 namespace sync_notifier {
 class SyncNotifier;
 }  // namespace sync_notifier
 
-namespace sync_pb {
-class PasswordSpecificsData;
-}  // namespace sync_pb
-
 namespace sync_api {
 
 class BaseTransaction;
 class HttpPostProviderFactory;
 struct UserShare;
 
 // Reasons due to which browser_sync::Cryptographer might require a passphrase.
 enum PassphraseRequiredReason {
   REASON_PASSPHRASE_NOT_REQUIRED = 0,  // Initial value.
   REASON_ENCRYPTION = 1,               // The cryptographer requires a
@@ skipping 20 matching lines @@
 // multiple threads interact with the same local sync repository (i.e. the
 // same sqlite database), they should share a single SyncManager instance.  The
 // caller should typically create one SyncManager for the lifetime of a user
 // session.
 class SyncManager {
  public:
   // SyncInternal contains the implementation of SyncManager, while abstracting
   // internal types from clients of the interface.
   class SyncInternal;
 
-  // TODO(zea): One day get passwords playing nicely with the rest of encryption
-  // and get rid of this.
-  class ExtraPasswordChangeRecordData {
-   public:
-    ExtraPasswordChangeRecordData();
-    explicit ExtraPasswordChangeRecordData(
-        const sync_pb::PasswordSpecificsData& data);
-    virtual ~ExtraPasswordChangeRecordData();
-
-    // Transfers ownership of the DictionaryValue to the caller.
-    virtual base::DictionaryValue* ToValue() const;
-
-    const sync_pb::PasswordSpecificsData& unencrypted() const;
-   private:
-    sync_pb::PasswordSpecificsData unencrypted_;
-  };
-
-  // ChangeRecord indicates a single item that changed as a result of a sync
-  // operation.  This gives the sync id of the node that changed, and the type
-  // of change.  To get the actual property values after an ADD or UPDATE, the
-  // client should get the node with InitByIdLookup(), using the provided id.
-  struct ChangeRecord {
-    enum Action {
-      ACTION_ADD,
-      ACTION_DELETE,
-      ACTION_UPDATE,
-    };
-    ChangeRecord();
-    ~ChangeRecord();
-
-    // Transfers ownership of the DictionaryValue to the caller.
-    base::DictionaryValue* ToValue(const BaseTransaction* trans) const;
-
-    int64 id;
-    Action action;
-    sync_pb::EntitySpecifics specifics;
-    linked_ptr<ExtraPasswordChangeRecordData> extra;
-  };
-
   // Status encapsulates detailed state about the internals of the SyncManager.
   struct Status {
     // Summary is a distilled set of important information that the end-user may
     // wish to be informed about (through UI, for example). Note that if a
     // summary state requires user interaction (such as auth failures), more
     // detailed information may be contained in additional status fields.
     enum Summary {
       // The internal instance is in an unrecognizable state. This should not
       // happen.
       INVALID = 0,
@@ skipping 101 matching lines @@
     // 2. Updates to existing items with synced parents & predecessors.
     // 3. New items with synced parents & predecessors.
     // 4. Items with parents & predecessors in |changes|.
     // 5. Repeat #4 until all items are in |changes|.
     //
     // Thus, an implementation of OnChangesApplied should be able to
     // process the change records in the order without having to worry about
     // forward dependencies.  But since deletions come before reparent
     // operations, a delete may temporarily orphan a node that is
     // updated later in the list.
-    virtual void OnChangesApplied(syncable::ModelType model_type,
-                                  const BaseTransaction* trans,
-                                  const ChangeRecord* changes,
-                                  int change_count) = 0;
+    virtual void OnChangesApplied(
+        syncable::ModelType model_type,
+        const BaseTransaction* trans,
+        const ImmutableChangeRecordList& changes) = 0;
 
     // OnChangesComplete gets called when the TransactionComplete event is
     // posted (after OnChangesApplied finishes), after the transaction lock
     // and the change channel mutex are released.
     //
     // The purpose of this function is to support processors that require
     // split-transactions changes. For example, if a model processor wants to
     // perform blocking I/O due to a change, it should calculate the changes
     // while holding the transaction lock (from within OnChangesApplied), buffer
     // those changes, let the transaction fall out of scope, and then commit
@@ skipping 299 matching lines @@
 };
 
 bool InitialSyncEndedForTypes(syncable::ModelTypeSet types, UserShare* share);
 
 // Returns the string representation of a PassphraseRequiredReason value.
 std::string PassphraseRequiredReasonToString(PassphraseRequiredReason reason);
 
 } // namespace sync_api
 
 #endif  // CHROME_BROWSER_SYNC_INTERNAL_API_SYNC_MANAGER_H_