[Sync] Move ChangeRecord into its own file (change_record.{h,cc})

chrome/browser/sync/js/js_sync_manager_observer_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/js/js_sync_manager_observer.h"
 
 #include <cstddef>
 
 #include "base/basictypes.h"
 #include "base/message_loop.h"
@@ skipping 223 matching lines @@
   }
 
   EXPECT_CALL(mock_js_event_handler_,
               HandleJsEvent("onEncryptionComplete",
                            HasDetailsAsDictionary(expected_details)));
 
   js_sync_manager_observer_.OnEncryptionComplete(encrypted_types);
   PumpLoop();
 }
 
-TEST_F(JsSyncManagerObserverTest, OnMigrationNeededForTypes) {
-  DictionaryValue expected_details;
-  ListValue* type_values = new ListValue();
-  expected_details.Set("types", type_values);
-  syncable::ModelTypeSet types;
-
-  for (int i = syncable::FIRST_REAL_MODEL_TYPE;
-       i < syncable::MODEL_TYPE_COUNT; ++i) {
-    syncable::ModelType type = syncable::ModelTypeFromInt(i);
-    types.insert(type);
-    type_values->Append(Value::CreateStringValue(
-        syncable::ModelTypeToString(type)));
-  }
-
-  EXPECT_CALL(mock_js_event_handler_,
-              HandleJsEvent("onMigrationNeededForTypes",
-                           HasDetailsAsDictionary(expected_details)));
-
-  js_sync_manager_observer_.OnMigrationNeededForTypes(types);
-  PumpLoop();
-}
-
 namespace {
 
 // Makes a node of the given model type.  Returns the id of the
 // newly-created node.
 int64 MakeNode(sync_api::UserShare* share, syncable::ModelType model_type) {
   sync_api::WriteTransaction trans(FROM_HERE, share);
   sync_api::ReadNode root_node(&trans);
   root_node.InitByRootLookup();
   sync_api::WriteNode node(&trans);
   EXPECT_TRUE(node.InitUniqueByCreation(
       model_type, root_node,
       syncable::ModelTypeToString(model_type)));
   node.SetIsFolder(false);
   return node.GetId();
 }
 
 }  // namespace
 
 TEST_F(JsSyncManagerObserverTest, OnChangesApplied) {
   InSequence dummy;
 
   TestUserShare test_user_share;
   test_user_share.SetUp();
 
   // We don't test with passwords as that requires additional setup.
 
   // Build a list of example ChangeRecords.
-  sync_api::SyncManager::ChangeRecord changes[syncable::MODEL_TYPE_COUNT];
+  sync_api::ChangeRecord changes[syncable::MODEL_TYPE_COUNT];
   for (int i = syncable::AUTOFILL_PROFILE;
        i < syncable::MODEL_TYPE_COUNT; ++i) {
     changes[i].id =
         MakeNode(test_user_share.user_share(), syncable::ModelTypeFromInt(i));
     switch (i % 3) {
       case 0:
         changes[i].action =
-            sync_api::SyncManager::ChangeRecord::ACTION_ADD;
+            sync_api::ChangeRecord::ACTION_ADD;
         break;
       case 1:
         changes[i].action =
-            sync_api::SyncManager::ChangeRecord::ACTION_UPDATE;
+            sync_api::ChangeRecord::ACTION_UPDATE;
         break;
       default:
         changes[i].action =
-            sync_api::SyncManager::ChangeRecord::ACTION_DELETE;
+            sync_api::ChangeRecord::ACTION_DELETE;
         break;
     }
     {
       sync_api::ReadTransaction trans(FROM_HERE, test_user_share.user_share());
       sync_api::ReadNode node(&trans);
       EXPECT_TRUE(node.InitByIdLookup(changes[i].id));
       changes[i].specifics = node.GetEntry()->Get(syncable::SPECIFICS);
     }
   }
 
@@ skipping 16 matching lines @@
     }
     EXPECT_CALL(mock_js_event_handler_,
                 HandleJsEvent("onChangesApplied",
                              HasDetailsAsDictionary(expected_details)));
   }
 
   // Fire OnChangesApplied() for each data type.
   for (int i = syncable::AUTOFILL_PROFILE;
        i < syncable::MODEL_TYPE_COUNT; ++i) {
     sync_api::ReadTransaction trans(FROM_HERE, test_user_share.user_share());
-    js_sync_manager_observer_.OnChangesApplied(syncable::ModelTypeFromInt(i),
-                                               &trans, &changes[i],
-                                               syncable::MODEL_TYPE_COUNT - i);
+    sync_api::ChangeRecordList
+        local_changes(changes + i, changes + arraysize(changes));
+    js_sync_manager_observer_.OnChangesApplied(
+        syncable::ModelTypeFromInt(i),
+        &trans,
+        sync_api::ImmutableChangeRecordList(&local_changes));
   }
 
   test_user_share.TearDown();
   PumpLoop();
 }
 
 }  // namespace
 }  // namespace browser_sync