Issue 7905: This fixes http://code.google.com/p/chromium/issues/detail?id=2529, which is...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7905: This fixes http://code.google.com/p/chromium/issues/detail?id=2529, which is... (Closed)

Created:
12 years, 2 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
Ben Goodger (Google), beng1

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

This fixes http://code.google.com/p/chromium/issues/detail?id=2529, which is tabs displaying Loading/Untitled in Chrome. We should display the page URL if the title of the page is blank. Fix on these lines. R=beng Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3852

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -4 lines)			Patch
M	chrome/browser/navigation_controller.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/navigation_entry.h	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/navigation_entry.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

12 years, 2 months ago (2008-10-23 01:57:11 UTC) #2

http://codereview.chromium.org/7905/diff/1/2
File chrome/browser/navigation_entry.h (right):

http://codereview.chromium.org/7905/diff/1/2#newcode222
Line 222: url_as_string_ = UTF8ToWide(url_.spec());
I actually think you should return the filename if not empty
(GURL::ExtractFilename), and if it's empty only then fall back to the URL.

Expand Messages | Collapse Messages