Issue 7841006: Revert 99801 - Simplify IqRequest interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7841006: Revert 99801 - Simplify IqRequest interface. (Closed)

Created:
9 years, 3 months ago by Sergey Ulanov

Modified:
9 years, 3 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, Paweł Hajdan Jr., dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 99801 - Simplify IqRequest interface. This is neccessary to make the interface usable with stanzas generated by JingleMessage::ToXml(). BUG=None TEST=Unittests Review URL: http://codereview.chromium.org/7809003 TBR=sergeyu@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99807

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -43 lines)			Patch
M	remoting/host/heartbeat_sender.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	remoting/host/heartbeat_sender_unittest.cc	View	3 chunks	+3 lines, -11 lines	0 comments	Download
M	remoting/host/register_support_host_request.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	remoting/host/register_support_host_request_unittest.cc	View	2 chunks	+4 lines, -7 lines	0 comments	Download
M	remoting/jingle_glue/iq_request.h	View	1 chunk	+10 lines, -6 lines	0 comments	Download
M	remoting/jingle_glue/iq_request.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	remoting/jingle_glue/iq_request_unittest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	remoting/jingle_glue/javascript_iq_request.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	remoting/jingle_glue/javascript_iq_request.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	remoting/jingle_glue/jingle_info_request.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	remoting/jingle_glue/mock_objects.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	remoting/jingle_glue/xmpp_iq_request.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	remoting/jingle_glue/xmpp_iq_request.cc	View	1 chunk	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages