Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 7809003: Simplify IqRequest interface. (Closed)

Created:
9 years, 3 months ago by Sergey Ulanov
Modified:
9 years, 3 months ago
Reviewers:
Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, Paweł Hajdan Jr., dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Simplify IqRequest interface. This is neccessary to make the interface usable with stanzas generated by JingleMessage::ToXml(). BUG=None TEST=Unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99801 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99851

Patch Set 1 #

Total comments: 4

Patch Set 2 : - #

Patch Set 3 : fix windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -46 lines) Patch
remoting/host/heartbeat_sender.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/heartbeat_sender_unittest.cc View 1 2 3 chunks +12 lines, -3 lines 0 comments Download
M remoting/host/register_support_host_request.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/register_support_host_request_unittest.cc View 1 2 2 chunks +8 lines, -4 lines 0 comments Download
M remoting/jingle_glue/iq_request.h View 1 chunk +6 lines, -10 lines 0 comments Download
M remoting/jingle_glue/iq_request.cc View 1 chunk +1 line, -3 lines 0 comments Download
M remoting/jingle_glue/iq_request_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/jingle_glue/javascript_iq_request.h View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/jingle_glue/javascript_iq_request.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M remoting/jingle_glue/jingle_info_request.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M remoting/jingle_glue/mock_objects.h View 1 chunk +1 line, -3 lines 0 comments Download
remoting/jingle_glue/xmpp_iq_request.h View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/jingle_glue/xmpp_iq_request.cc View 1 chunk +3 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sergey Ulanov
9 years, 3 months ago (2011-08-30 20:56:24 UTC) #1
Wez
LGTM http://codereview.chromium.org/7809003/diff/1/remoting/host/heartbeat_sender_unittest.cc File remoting/host/heartbeat_sender_unittest.cc (right): http://codereview.chromium.org/7809003/diff/1/remoting/host/heartbeat_sender_unittest.cc#newcode53 remoting/host/heartbeat_sender_unittest.cc:53: // being send. nit: send -> sent. http://codereview.chromium.org/7809003/diff/1/remoting/host/heartbeat_sender_unittest.cc#newcode69 ...
9 years, 3 months ago (2011-08-31 03:42:34 UTC) #2
Sergey Ulanov
http://codereview.chromium.org/7809003/diff/1/remoting/host/heartbeat_sender_unittest.cc File remoting/host/heartbeat_sender_unittest.cc (right): http://codereview.chromium.org/7809003/diff/1/remoting/host/heartbeat_sender_unittest.cc#newcode53 remoting/host/heartbeat_sender_unittest.cc:53: // being send. On 2011/08/31 03:42:34, Wez wrote: > ...
9 years, 3 months ago (2011-08-31 23:26:26 UTC) #3
commit-bot: I haz the power
9 years, 3 months ago (2011-09-01 02:12:18 UTC) #4
Can't process patch for file remoting/jingle_glue/xmpp_iq_request.h.
File's status is None, patchset upload is incomplete.

Powered by Google App Engine
This is Rietveld 408576698