Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: remoting/jingle_glue/iq_request.h

Issue 7841006: Revert 99801 - Simplify IqRequest interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/register_support_host_request_unittest.cc ('k') | remoting/jingle_glue/iq_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/jingle_glue/iq_request.h
===================================================================
--- remoting/jingle_glue/iq_request.h (revision 99806)
+++ remoting/jingle_glue/iq_request.h (working copy)
@@ -25,19 +25,23 @@
public:
typedef base::Callback<void(const buzz::XmlElement*)> ReplyCallback;
- static buzz::XmlElement* MakeIqStanza(const std::string& type,
- const std::string& addressee,
- buzz::XmlElement* iq_body);
-
IqRequest() {}
virtual ~IqRequest() {}
- // Sends Iq stanza. Takes ownership of |stanza|.
- virtual void SendIq(buzz::XmlElement* stanza) = 0;
+ // Sends stanza of type |type| to |addressee|. |iq_body| contains body of
+ // the stanza. Takes pwnership of |iq_body|.
+ virtual void SendIq(const std::string& type, const std::string& addressee,
+ buzz::XmlElement* iq_body) = 0;
// Sets callback that is called when reply stanza is received.
virtual void set_callback(const ReplyCallback& callback) = 0;
+ protected:
+ static buzz::XmlElement* MakeIqStanza(const std::string& type,
+ const std::string& addressee,
+ buzz::XmlElement* iq_body,
+ const std::string& id);
+
private:
FRIEND_TEST_ALL_PREFIXES(IqRequestTest, MakeIqStanza);
« no previous file with comments | « remoting/host/register_support_host_request_unittest.cc ('k') | remoting/jingle_glue/iq_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698