Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: remoting/host/register_support_host_request_unittest.cc

Issue 7841006: Revert 99801 - Simplify IqRequest interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/register_support_host_request.cc ('k') | remoting/jingle_glue/iq_request.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/register_support_host_request_unittest.cc
===================================================================
--- remoting/host/register_support_host_request_unittest.cc (revision 99806)
+++ remoting/host/register_support_host_request_unittest.cc (working copy)
@@ -76,8 +76,8 @@
.WillOnce(Return(iq_request));
XmlElement* sent_iq = NULL;
- EXPECT_CALL(*iq_request, SendIq(NotNull()))
- .WillOnce(SaveArg<0>(&sent_iq));
+ EXPECT_CALL(*iq_request, SendIq(buzz::STR_SET, kChromotingBotJid, NotNull()))
+ .WillOnce(SaveArg<2>(&sent_iq));
request->OnSignallingConnected(&signal_strategy_, kTestJid);
message_loop_.RunAllPending();
@@ -86,14 +86,11 @@
scoped_ptr<XmlElement> stanza(sent_iq);
ASSERT_TRUE(stanza != NULL);
- EXPECT_EQ(stanza->Attr(buzz::QName("", "to")), kChromotingBotJid);
- EXPECT_EQ(stanza->Attr(buzz::QName("", "type")), "set");
-
EXPECT_EQ(QName(kChromotingXmlNamespace, "register-support-host"),
- stanza->FirstElement()->Name());
+ stanza->Name());
QName signature_tag(kChromotingXmlNamespace, "signature");
- XmlElement* signature = stanza->FirstElement()->FirstNamed(signature_tag);
+ XmlElement* signature = stanza->FirstNamed(signature_tag);
ASSERT_TRUE(signature != NULL);
EXPECT_TRUE(stanza->NextNamed(signature_tag) == NULL);
« no previous file with comments | « remoting/host/register_support_host_request.cc ('k') | remoting/jingle_glue/iq_request.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698