Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1847)

Issue 7753020: Revert recent changes to base::Value (Closed)

Created:
9 years, 4 months ago by stevenjb
Modified:
9 years, 4 months ago
Reviewers:
tony, Evan Martin
CC:
chromium-reviews, jam, Erik does not do reviews, Paweł Hajdan Jr., kkania, mihaip+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org, davemoore+watch_chromium.org, tfarina, satorux1
Visibility:
Public.

Description

Revert recent changes to base::Value Reverts: 98223: base: Add AsList() function to Value API. 98266: base: Add AsBinary() function to Value API. There are two issues with these commits: 1. libcros uses base::Value to pass data to Chrome. It includes values.h from libchrome which contains its own copy. This is a terrible design flaw in libcros and is being addressed (http://crosbug.com/19576), however we need some time to address this before we can make these changes without breaking Chrome on ChromeOS. 2. AsList() and AsBinary() should be const. The fact that they were not const caused re-factoring that changed const Value& input arguments to Value*, which is against the spec. When we re-introduce this, these members should be made const. BUG=chromium-os:19604 TEST=Check bots + ChromeOS autotests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98378

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -248 lines) Patch
M base/json/json_reader_unittest.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M base/values.h View 3 chunks +0 lines, -5 lines 0 comments Download
M base/values.cc View 8 chunks +9 lines, -25 lines 0 comments Download
M base/values_unittest.cc View 1 chunk +9 lines, -8 lines 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/cros/native_network_parser.h View 9 chunks +14 lines, -24 lines 0 comments Download
M chrome/browser/chromeos/cros/native_network_parser.cc View 24 chunks +80 lines, -77 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.cc View 5 chunks +11 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/cros/network_parser.h View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/cros/network_parser.cc View 13 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/extensions/extension_bookmarks_module.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_webrequest_api_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/common/json_value_serializer_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/renderer/extensions/extension_process_bindings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/automation/automation_json_requests.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/automation/javascript_execution_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/automation/javascript_message_utils.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/automation/tab_proxy.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/automation/value_conversion_traits.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/perf/dom_checker_uitest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/webdriver/commands/response.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/commands/response.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/webdriver_dispatch.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/test/webdriver/webdriver_session.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/speech/speech_recognition_request.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/web_ui_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
stevenjb
Unfortunately, unless we revert these there is no quick way to fix chromeos. The libcros ...
9 years, 4 months ago (2011-08-26 00:24:10 UTC) #1
stevenjb
9 years, 4 months ago (2011-08-26 00:32:22 UTC) #2
TBR: tony@chromium.org

Will push once some of the bots complete so we can get this in tonight's build.

Powered by Google App Engine
This is Rietveld 408576698