Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: chrome/browser/extensions/extension_webrequest_api_unittest.cc

Issue 7753020: Revert recent changes to base::Value (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_tabs_module.cc ('k') | chrome/common/json_value_serializer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_webrequest_api_unittest.cc
diff --git a/chrome/browser/extensions/extension_webrequest_api_unittest.cc b/chrome/browser/extensions/extension_webrequest_api_unittest.cc
index 0791a71a2315c1ed02c0f1dabdae57c4b426043d..8398433af1a7584333a1892b82f555d137d610e8 100644
--- a/chrome/browser/extensions/extension_webrequest_api_unittest.cc
+++ b/chrome/browser/extensions/extension_webrequest_api_unittest.cc
@@ -477,12 +477,13 @@ TEST_P(ExtensionWebRequestHeaderModificationTest, TestModifications) {
scoped_ptr<Value> event_arg_value(
JSONStringValueSerializer(event_arg_string).Deserialize(NULL, NULL));
- ASSERT_TRUE(event_arg_value.get());
- ListValue* list = event_arg_value->AsList();
- ASSERT_TRUE(list);
+ ASSERT_TRUE(event_arg_value.get() &&
+ event_arg_value->IsType(Value::TYPE_LIST));
DictionaryValue* event_arg_dict = NULL;
- ASSERT_TRUE(list->GetDictionary(0, &event_arg_dict));
+ ASSERT_TRUE(
+ static_cast<ListValue*>(event_arg_value.get())->GetDictionary(
+ 0, &event_arg_dict));
ListValue* request_headers = NULL;
ASSERT_TRUE(event_arg_dict->GetList(keys::kRequestHeadersKey,
« no previous file with comments | « chrome/browser/extensions/extension_tabs_module.cc ('k') | chrome/common/json_value_serializer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698