chrome/test/webdriver/webdriver_session.cc - Issue 7753020: Revert recent changes to base::Value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/webdriver/webdriver_session.cc

Issue 7753020: Revert recent changes to base::Value (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/webdriver/webdriver_session.cc

diff --git a/chrome/test/webdriver/webdriver_session.cc b/chrome/test/webdriver/webdriver_session.cc

index c3a7c11ef2bbb64fdc1d57f722c338a43611bfef..1a764a845f78678d4e2e617c302fe26f80c0e87a 100644

--- a/chrome/test/webdriver/webdriver_session.cc

+++ b/chrome/test/webdriver/webdriver_session.cc

@@ -1240,9 +1240,9 @@ Error* Session::ExecuteFindElementScriptAndParse(

virtual ~FindElementsParser() { }

virtual bool Parse(base::Value* value) const OVERRIDE {

- ListValue* list = value->AsList();

- if (!list)

+ if (!value->IsType(Value::TYPE_LIST))

return false;

+ ListValue* list = static_cast<ListValue*>(value);

for (size_t i = 0; i < list->GetSize(); ++i) {

ElementId element;

Value* element_value = NULL;