Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: chrome/test/automation/tab_proxy.cc

Issue 7753020: Revert recent changes to base::Value (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/automation/tab_proxy.cc
diff --git a/chrome/test/automation/tab_proxy.cc b/chrome/test/automation/tab_proxy.cc
index d30fd7d402f63f1bd3a6dff3d62c4043d9c07229..49cd00c2dfe1dfc0f75838065da2b0e6a081d8b5 100644
--- a/chrome/test/automation/tab_proxy.cc
+++ b/chrome/test/automation/tab_proxy.cc
@@ -266,9 +266,9 @@ bool TabProxy::ExecuteAndExtractString(const std::wstring& frame_xpath,
if (!succeeded)
return false;
- DCHECK(root->AsList());
+ DCHECK(root->IsType(Value::TYPE_LIST));
Value* value = NULL;
- succeeded = root->AsList()->Get(0, &value);
+ succeeded = static_cast<ListValue*>(root)->Get(0, &value);
if (succeeded) {
string16 read_value;
succeeded = value->GetAsString(&read_value);
@@ -291,9 +291,9 @@ bool TabProxy::ExecuteAndExtractBool(const std::wstring& frame_xpath,
return false;
bool read_value = false;
- DCHECK(root->AsList());
+ DCHECK(root->IsType(Value::TYPE_LIST));
Value* value = NULL;
- succeeded = root->AsList()->Get(0, &value);
+ succeeded = static_cast<ListValue*>(root)->Get(0, &value);
if (succeeded) {
succeeded = value->GetAsBoolean(&read_value);
if (succeeded) {
@@ -314,9 +314,9 @@ bool TabProxy::ExecuteAndExtractInt(const std::wstring& frame_xpath,
return false;
int read_value = 0;
- DCHECK(root->AsList());
+ DCHECK(root->IsType(Value::TYPE_LIST));
Value* value = NULL;
- succeeded = root->AsList()->Get(0, &value);
+ succeeded = static_cast<ListValue*>(root)->Get(0, &value);
if (succeeded) {
succeeded = value->GetAsInteger(&read_value);
if (succeeded) {
« no previous file with comments | « chrome/test/automation/javascript_message_utils.h ('k') | chrome/test/automation/value_conversion_traits.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698