Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: chrome/test/automation/tab_proxy.cc

Issue 7714004: base: Add AsList() function to Value API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: convert one more case in extension_webrequest_api_unittest.cc Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/automation/tab_proxy.cc
diff --git a/chrome/test/automation/tab_proxy.cc b/chrome/test/automation/tab_proxy.cc
index 49cd00c2dfe1dfc0f75838065da2b0e6a081d8b5..66e31eb158e2f084fbc07490f081a03e3a9760af 100644
--- a/chrome/test/automation/tab_proxy.cc
+++ b/chrome/test/automation/tab_proxy.cc
@@ -266,7 +266,7 @@ bool TabProxy::ExecuteAndExtractString(const std::wstring& frame_xpath,
if (!succeeded)
return false;
- DCHECK(root->IsType(Value::TYPE_LIST));
+ DCHECK(root->AsList());
Value* value = NULL;
succeeded = static_cast<ListValue*>(root)->Get(0, &value);
Evan Martin 2011/08/23 19:04:11 can use AsList here
tfarina 2011/08/23 20:00:33 Done.
if (succeeded) {
@@ -291,7 +291,7 @@ bool TabProxy::ExecuteAndExtractBool(const std::wstring& frame_xpath,
return false;
bool read_value = false;
- DCHECK(root->IsType(Value::TYPE_LIST));
+ DCHECK(root->AsList());
Value* value = NULL;
succeeded = static_cast<ListValue*>(root)->Get(0, &value);
Evan Martin 2011/08/23 19:04:11 here too
tfarina 2011/08/23 20:00:33 Done.
if (succeeded) {
@@ -314,7 +314,7 @@ bool TabProxy::ExecuteAndExtractInt(const std::wstring& frame_xpath,
return false;
int read_value = 0;
- DCHECK(root->IsType(Value::TYPE_LIST));
+ DCHECK(root->AsList());
Value* value = NULL;
succeeded = static_cast<ListValue*>(root)->Get(0, &value);
Evan Martin 2011/08/23 19:04:11 here too
tfarina 2011/08/23 20:00:33 Done.
if (succeeded) {

Powered by Google App Engine
This is Rietveld 408576698