Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7963)

Unified Diff: chrome/test/automation/value_conversion_traits.cc

Issue 7714004: base: Add AsList() function to Value API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: convert one more case in extension_webrequest_api_unittest.cc Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/automation/value_conversion_traits.cc
diff --git a/chrome/test/automation/value_conversion_traits.cc b/chrome/test/automation/value_conversion_traits.cc
index f5c1f2c00ac66f7278b5cffa3243705ed2ac72dd..801b80a2d7248c7095e96557491baa9340d15a02 100644
--- a/chrome/test/automation/value_conversion_traits.cc
+++ b/chrome/test/automation/value_conversion_traits.cc
@@ -71,14 +71,15 @@ Value* ValueConversionTraits<ListValue*>::CreateValueFrom(const ListValue* t) {
bool ValueConversionTraits<ListValue*>::SetFromValue(const Value* value,
ListValue** t) {
- if (!value->IsType(Value::TYPE_LIST))
+ const ListValue* list = value->AsList();
+ if (!list)
return false;
- *t = static_cast<const ListValue*>(value)->DeepCopy();
+ *t = list->DeepCopy();
return true;
}
bool ValueConversionTraits<ListValue*>::CanConvert(const Value* value) {
- return value->IsType(Value::TYPE_LIST);
+ return value->AsList();
}
Value* ValueConversionTraits<DictionaryValue*>::CreateValueFrom(

Powered by Google App Engine
This is Rietveld 408576698