chrome/test/automation/javascript_message_utils.h - Issue 7714004: base: Add AsList() function to Value API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/automation/javascript_message_utils.h

Issue 7714004: base: Add AsList() function to Value API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: convert one more case in extension_webrequest_api_unittest.cc Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/automation/javascript_message_utils.h

diff --git a/chrome/test/automation/javascript_message_utils.h b/chrome/test/automation/javascript_message_utils.h

index e4b61f4d9961f222f192336398e99dd2dc185cf8..e1d84c37775c50ff3329370ea28c0ffbc7c959c8 100644

--- a/chrome/test/automation/javascript_message_utils.h

+++ b/chrome/test/automation/javascript_message_utils.h

@@ -52,10 +52,10 @@ struct ValueConversionTraits<std::vector<T> > {

return value;

}

static bool SetFromValue(const Value* value, std::vector<T>* t) {

- if (!value->IsType(Value::TYPE_LIST))

+ const ListValue* list_value = value->AsList();

+ if (!list_value)

return false;

- const ListValue* list_value = static_cast<const ListValue*>(value);

ListValue::const_iterator iter;

for (iter = list_value->begin(); iter != list_value->end(); ++iter) {

if (!ValueConversionTraits<T>::CanConvert(*iter))