Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/automation/automation_json_requests.cc

Issue 7714004: base: Add AsList() function to Value API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: convert one more case in extension_webrequest_api_unittest.cc Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/renderer/extensions/extension_process_bindings.cc ('K') | « chrome/renderer/extensions/extension_process_bindings.cc ('k') | chrome/test/automation/javascript_execution_controller.cc » ('j') | chrome/test/automation/tab_proxy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/automation/automation_json_requests.cc
diff --git a/chrome/test/automation/automation_json_requests.cc b/chrome/test/automation/automation_json_requests.cc
index ab0de317a05c72335a198dd4119fb645c6b642bc..80edc5233425bc2f373ea36d982d3a1580a4b385 100644
--- a/chrome/test/automation/automation_json_requests.cc
+++ b/chrome/test/automation/automation_json_requests.cc
@@ -187,7 +187,7 @@ bool SendExecuteJavascriptJSONRequest(
JSONStringValueSerializer deserializer(json);
Value* value = deserializer.Deserialize(NULL, NULL);
- if (!value || !value->IsType(Value::TYPE_LIST)) {
+ if (!value || !value->AsList()) {
LOG(ERROR) << "Unable to deserialize returned JSON";
return false;
}
@@ -297,7 +297,7 @@ bool SendGetCookiesJSONRequest(
if (!reply_dict.Remove("cookies", &cookies_unscoped_value))
return false;
scoped_ptr<Value> cookies_value(cookies_unscoped_value);
- if (!cookies_value->IsType(Value::TYPE_LIST))
+ if (!cookies_value->AsList())
return false;
*cookies = static_cast<ListValue*>(cookies_value.release());
Evan Martin 2011/08/23 19:04:11 same here
tfarina 2011/08/23 20:00:33 Done.
return true;
« chrome/renderer/extensions/extension_process_bindings.cc ('K') | « chrome/renderer/extensions/extension_process_bindings.cc ('k') | chrome/test/automation/javascript_execution_controller.cc » ('j') | chrome/test/automation/tab_proxy.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698