base: Add AsList() function to Value API.

base: Add AsList() function to Value API.

This function should simplify some constructions.

Instead of:

if (!value->IsType(Value::TYPE_LIST))
  return false;
ListValue* list_value = static_cast<ListValue*>(value);

You can do:

ListValue* list_value = value->AsList();
if (!list_value)
  return false;

BUG=None
TEST=base_unittests --gtest_filter=Values*

R=evan@chromium.org,tony@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98223

[Evan Martin, 2011-08-23 18:15:25]

only looked at the first half

http://codereview.chromium.org/7714004/diff/5001/chrome/browser/autocomplete/...
File chrome/browser/autocomplete/search_provider.cc (right):

http://codereview.chromium.org/7714004/diff/5001/chrome/browser/autocomplete/...
chrome/browser/autocomplete/search_provider.cc:473: description_list =
static_cast<ListValue*>(description_val);
if (root_list->Get(2, &description_val))
  description_list = description_val->AsList();

http://codereview.chromium.org/7714004/diff/5001/chrome/browser/chromeos/cros...
File chrome/browser/chromeos/cros/native_network_parser.cc (right):

http://codereview.chromium.org/7714004/diff/5001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/native_network_parser.cc:216: static_cast<const
ListValue&>(value),
We can remove the casts in this file with something like:

if (ListValue* list = value.AsList()) {
...as before, but using list.
}

http://codereview.chromium.org/7714004/diff/5001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_tabs_module.cc (right):

http://codereview.chromium.org/7714004/diff/5001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_tabs_module.cc:421: const ListValue*
url_list = static_cast<const ListValue*>(url_value);
same transformation here (can set url_list in the if statement)

http://codereview.chromium.org/7714004/diff/5001/chrome/common/json_value_ser...
File chrome/common/json_value_serializer_unittest.cc (right):

http://codereview.chromium.org/7714004/diff/5001/chrome/common/json_value_ser...
chrome/common/json_value_serializer_unittest.cc:199: ListValue* list =
static_cast<ListValue*>(root.get());
ASSERT_TRUE(root.get());
ListValue* list = root->AsList();
ASSERT_TRUE(list)


(I know it's one more line, but I think it better conveys what's trying to be
tested and it eliminates a cast)

[tfarina, 2011-08-23 18:26:36]

Thanks for the feedback Evan!

Fixed the first half reviewed!

Thanks for spotting and suggesting the fixes (I was not sure how to fix them) ;)

http://codereview.chromium.org/7714004/diff/5001/chrome/browser/autocomplete/...
File chrome/browser/autocomplete/search_provider.cc (right):

http://codereview.chromium.org/7714004/diff/5001/chrome/browser/autocomplete/...
chrome/browser/autocomplete/search_provider.cc:473: description_list =
static_cast<ListValue*>(description_val);
On 2011/08/23 18:15:26, Evan Martin wrote:
> if (root_list->Get(2, &description_val))
>   description_list = description_val->AsList();

Done.

http://codereview.chromium.org/7714004/diff/5001/chrome/browser/chromeos/cros...
File chrome/browser/chromeos/cros/native_network_parser.cc (right):

http://codereview.chromium.org/7714004/diff/5001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/native_network_parser.cc:216: static_cast<const
ListValue&>(value),
On 2011/08/23 18:15:26, Evan Martin wrote:
> We can remove the casts in this file with something like:
> 
> if (ListValue* list = value.AsList()) {
> ...as before, but using list.
> }

Done.

http://codereview.chromium.org/7714004/diff/5001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_tabs_module.cc (right):

http://codereview.chromium.org/7714004/diff/5001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_tabs_module.cc:421: const ListValue*
url_list = static_cast<const ListValue*>(url_value);
On 2011/08/23 18:15:26, Evan Martin wrote:
> same transformation here (can set url_list in the if statement)

Done.

http://codereview.chromium.org/7714004/diff/5001/chrome/common/json_value_ser...
File chrome/common/json_value_serializer_unittest.cc (right):

http://codereview.chromium.org/7714004/diff/5001/chrome/common/json_value_ser...
chrome/common/json_value_serializer_unittest.cc:199: ListValue* list =
static_cast<ListValue*>(root.get());
On 2011/08/23 18:15:26, Evan Martin wrote:
> ASSERT_TRUE(root.get());
> ListValue* list = root->AsList();
> ASSERT_TRUE(list)
> 
> 
> (I know it's one more line, but I think it better conveys what's trying to be
> tested and it eliminates a cast)

Done.

[Evan Martin, 2011-08-23 19:04:07]

http://codereview.chromium.org/7714004/diff/4025/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_bookmarks_module.cc (right):

http://codereview.chromium.org/7714004/diff/4025/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_bookmarks_module.cc:289: const ListValue*
ids = static_cast<const ListValue*>(arg0);
if (ListValue ids = ...

http://codereview.chromium.org/7714004/diff/4025/chrome/renderer/extensions/e...
File chrome/renderer/extensions/extension_process_bindings.cc (right):

http://codereview.chromium.org/7714004/diff/4025/chrome/renderer/extensions/e...
chrome/renderer/extensions/extension_process_bindings.cc:475: return
StartRequestCommon(args, static_cast<ListValue*>(value_args.get()));
Can eliminate this cast with a temp variable.
Or make it use AsList() again

http://codereview.chromium.org/7714004/diff/4025/chrome/test/automation/autom...
File chrome/test/automation/automation_json_requests.cc (right):

http://codereview.chromium.org/7714004/diff/4025/chrome/test/automation/autom...
chrome/test/automation/automation_json_requests.cc:194: scoped_ptr<ListValue>
list(static_cast<ListValue*>(value));
same here

http://codereview.chromium.org/7714004/diff/4025/chrome/test/automation/autom...
chrome/test/automation/automation_json_requests.cc:302: *cookies =
static_cast<ListValue*>(cookies_value.release());
same here

http://codereview.chromium.org/7714004/diff/4025/chrome/test/automation/tab_p...
File chrome/test/automation/tab_proxy.cc (right):

http://codereview.chromium.org/7714004/diff/4025/chrome/test/automation/tab_p...
chrome/test/automation/tab_proxy.cc:271: succeeded =
static_cast<ListValue*>(root)->Get(0, &value);
can use AsList here

http://codereview.chromium.org/7714004/diff/4025/chrome/test/automation/tab_p...
chrome/test/automation/tab_proxy.cc:296: succeeded =
static_cast<ListValue*>(root)->Get(0, &value);
here too

http://codereview.chromium.org/7714004/diff/4025/chrome/test/automation/tab_p...
chrome/test/automation/tab_proxy.cc:319: succeeded =
static_cast<ListValue*>(root)->Get(0, &value);
here too

[tfarina, 2011-08-23 20:00:33]

http://codereview.chromium.org/7714004/diff/4025/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_bookmarks_module.cc (right):

http://codereview.chromium.org/7714004/diff/4025/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_bookmarks_module.cc:289: const ListValue*
ids = static_cast<const ListValue*>(arg0);
On 2011/08/23 19:04:11, Evan Martin wrote:
> if (ListValue ids = ...

Done.

http://codereview.chromium.org/7714004/diff/4025/chrome/renderer/extensions/e...
File chrome/renderer/extensions/extension_process_bindings.cc (right):

http://codereview.chromium.org/7714004/diff/4025/chrome/renderer/extensions/e...
chrome/renderer/extensions/extension_process_bindings.cc:475: return
StartRequestCommon(args, static_cast<ListValue*>(value_args.get()));
On 2011/08/23 19:04:11, Evan Martin wrote:
> Can eliminate this cast with a temp variable.
> Or make it use AsList() again

Done.

http://codereview.chromium.org/7714004/diff/4025/chrome/test/automation/autom...
File chrome/test/automation/automation_json_requests.cc (right):

http://codereview.chromium.org/7714004/diff/4025/chrome/test/automation/autom...
chrome/test/automation/automation_json_requests.cc:194: scoped_ptr<ListValue>
list(static_cast<ListValue*>(value));
On 2011/08/23 19:04:11, Evan Martin wrote:
> same here

Done.

http://codereview.chromium.org/7714004/diff/4025/chrome/test/automation/autom...
chrome/test/automation/automation_json_requests.cc:302: *cookies =
static_cast<ListValue*>(cookies_value.release());
On 2011/08/23 19:04:11, Evan Martin wrote:
> same here

Done.

http://codereview.chromium.org/7714004/diff/4025/chrome/test/automation/tab_p...
File chrome/test/automation/tab_proxy.cc (right):

http://codereview.chromium.org/7714004/diff/4025/chrome/test/automation/tab_p...
chrome/test/automation/tab_proxy.cc:271: succeeded =
static_cast<ListValue*>(root)->Get(0, &value);
On 2011/08/23 19:04:11, Evan Martin wrote:
> can use AsList here

Done.

http://codereview.chromium.org/7714004/diff/4025/chrome/test/automation/tab_p...
chrome/test/automation/tab_proxy.cc:296: succeeded =
static_cast<ListValue*>(root)->Get(0, &value);
On 2011/08/23 19:04:11, Evan Martin wrote:
> here too

Done.

http://codereview.chromium.org/7714004/diff/4025/chrome/test/automation/tab_p...
chrome/test/automation/tab_proxy.cc:319: succeeded =
static_cast<ListValue*>(root)->Get(0, &value);
On 2011/08/23 19:04:11, Evan Martin wrote:
> here too

Done.

[tony, 2011-08-24 19:37:51]

LGTM.  You need evan to LG for OWNERS.

http://codereview.chromium.org/7714004/diff/2017/chrome/test/webdriver/webdri...
File chrome/test/webdriver/webdriver_dispatch.cc (right):

http://codereview.chromium.org/7714004/diff/2017/chrome/test/webdriver/webdri...
chrome/test/webdriver/webdriver_dispatch.cc:177: ListValue* list_value =
const_cast<Value*>(value)->AsList();
Rather than const_cast, we should just change the line above to not be const.

[Evan Martin, 2011-08-24 20:06:09]

owners LGTM

[tfarina, 2011-08-24 20:46:51]

http://codereview.chromium.org/7714004/diff/2017/chrome/test/webdriver/webdri...
File chrome/test/webdriver/webdriver_dispatch.cc (right):

http://codereview.chromium.org/7714004/diff/2017/chrome/test/webdriver/webdri...
chrome/test/webdriver/webdriver_dispatch.cc:177: ListValue* list_value =
const_cast<Value*>(value)->AsList();
On 2011/08/24 19:37:51, tony wrote:
> Rather than const_cast, we should just change the line above to not be const.

Done.

[kkania, 2011-08-26 00:43:37]

This change has a small bug in
chrome/test/automation/automation_json_requests.cc:302. You need to release the
value*. I see this CL is being reverted for other reasons
(http://codereview.chromium.org/7753020/). If you reland, please fix first.