base: Add AsList() function to Value API.

chrome/test/webdriver/webdriver_dispatch.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/webdriver/webdriver_dispatch.h"
 
 #include <sstream>
 #include <string>
 #include <vector>
 
@@ skipping 156 matching lines @@
       break;
     }
 
     case kBadRequest:
     case kSessionNotFound:
       http_response->set_status(status);
       break;
 
     case kMethodNotAllowed: {
       const Value* const value = command_response.GetValue();
-      if (!value->IsType(Value::TYPE_LIST)) {
+      ListValue* list_value = const_cast<Value*>(value)->AsList();

[tony, 2011/08/24 19:37:51]

Rather than const_cast, we should just change the line above to not be const.

[tfarina, 2011/08/24 20:46:51]

Done.

+      if (!list_value) {
         // This should never happen.
         http_response->set_status(HttpResponse::kInternalServerError);
         http_response->SetBody(
             "Unable to set 'Allow' header: response value was "
             "not a list of strings: " + command_response.ToJSON());
         return;
       }
 
-      const ListValue* const list_value =
-          static_cast<const ListValue* const>(value);
       std::vector<std::string> allowed_methods;
       for (size_t i = 0; i < list_value->GetSize(); ++i) {
         std::string method;
         if (list_value->GetString(i, &method)) {
           allowed_methods.push_back(method);
         } else {
           // This should never happen.
           http_response->set_status(HttpResponse::kInternalServerError);
           http_response->SetBody(
               "Unable to set 'Allow' header: response value was "
@@ skipping 134 matching lines @@
 void Dispatcher::SetNotImplemented(const std::string& pattern) {
   mg_set_uri_callback(context_, (root_ + pattern).c_str(),
                       &SendNotImplementedError, NULL);
 }
 
 void Dispatcher::ForbidAllOtherRequests() {
   mg_set_uri_callback(context_, "*", &SendForbidden, NULL);
 }
 
 }  // namespace webdriver