base: Add AsList() function to Value API.

chrome/browser/extensions/extension_tabs_module.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_tabs_module.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/base64.h"
@@ skipping 399 matching lines @@
     if (args->HasKey(keys::kUrlKey)) {
       Value* url_value;
       std::vector<std::string> url_strings;
       args->Get(keys::kUrlKey, &url_value);
 
       // First, get all the URLs the client wants to open.
       if (url_value->IsType(Value::TYPE_STRING)) {
         std::string url_string;
         url_value->GetAsString(&url_string);
         url_strings.push_back(url_string);
-      } else if (url_value->IsType(Value::TYPE_LIST)) {
+      } else if (url_value->AsList()) {
         const ListValue* url_list = static_cast<const ListValue*>(url_value);

[Evan Martin, 2011/08/23 18:15:26]

same transformation here (can set url_list in the if statement)

[tfarina, 2011/08/23 18:26:36]

Done.

         for (size_t i = 0; i < url_list->GetSize(); ++i) {
           std::string url_string;
           EXTENSION_FUNCTION_VALIDATE(url_list->GetString(i, &url_string));
           url_strings.push_back(url_string);
         }
       }
 
       // Second, resolve, validate and convert them to GURLs.
       for (std::vector<std::string>::iterator i = url_strings.begin();
            i != url_strings.end(); ++i) {
@@ skipping 944 matching lines @@
   // called for every API call the extension made.
   GotLanguage(language);
 }
 
 void DetectTabLanguageFunction::GotLanguage(const std::string& language) {
   result_.reset(Value::CreateStringValue(language.c_str()));
   SendResponse(true);
 
   Release();  // Balanced in Run()
 }