base: Add AsList() function to Value API.

chrome/browser/autocomplete/search_provider.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/search_provider.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/callback.h"
@@ skipping 434 matching lines @@
       URLFetcher::GET, this);
   fetcher->set_request_context(profile_->GetRequestContext());
   fetcher->Start();
   return fetcher;
 }
 
 bool SearchProvider::ParseSuggestResults(Value* root_val,
                                          bool is_keyword,
                                          const string16& input_text,
                                          SuggestResults* suggest_results) {
-  if (!root_val->IsType(Value::TYPE_LIST))
+  ListValue* root_list = root_val->AsList();
+  if (!root_list)
     return false;
-  ListValue* root_list = static_cast<ListValue*>(root_val);
 
   Value* query_val;
   string16 query_str;
   Value* result_val;
   if ((root_list->GetSize() < 2) || !root_list->Get(0, &query_val) ||
       !query_val->GetAsString(&query_str) ||
       (query_str != input_text) ||
-      !root_list->Get(1, &result_val) || !result_val->IsType(Value::TYPE_LIST))
+      !root_list->Get(1, &result_val) || !result_val->AsList())
     return false;
 
   ListValue* description_list = NULL;
   if (root_list->GetSize() > 2) {
     // 3rd element: Description list.
     Value* description_val;
-    if (root_list->Get(2, &description_val) &&
-        description_val->IsType(Value::TYPE_LIST))
+    if (root_list->Get(2, &description_val) && description_val->AsList())
       description_list = static_cast<ListValue*>(description_val);

[Evan Martin, 2011/08/23 18:15:26]

if (root_list->Get(2, &description_val))
  description_list = description_val->AsList();

[tfarina, 2011/08/23 18:26:36]

Done.

   }
 
   // We don't care about the query URL list (the fourth element in the
   // response) for now.
 
   // Parse optional data in the results from the Suggest server if any.
   ListValue* type_list = NULL;
   // 5th argument: Optional key-value pairs.
   // TODO: We may iterate the 5th+ arguments of the root_list if any other
   // optional data are defined.
@@ skipping 459 matching lines @@
 
   return match;
 }
 
 void SearchProvider::UpdateDone() {
   // We're done when there are no more suggest queries pending (this is set to 1
   // when the timer is started) and we're not waiting on instant.
   done_ = ((suggest_results_pending_ == 0) &&
            (instant_finalized_ || !InstantController::IsEnabled(profile_)));
 }