WindowOpenDisposition should not be exposed in base and ui modules. (1) Gdk refactoring

NOTE: 
The last goal of this series of patches is not to expose WindowOpenDisposition in ui and base modules.

In the series of these patches, 
 Browser::ExecuteCommandWithDisposition and these kind of functions will be changed to 
  Browser::ExecuteCommandWithEventFlags,
which takes platform independent event flags (ui::EventFlags)

The previous patch (http://codereview.chromium.org/6893046/) was so big, I decided them into much small patches.
BUG=93700
TEST=GTKUtilTest

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98790

[Paweł Hajdan Jr., 2011-08-24 17:15:01]

Drive-by with testing comments. No need to wait for me.

http://codereview.chromium.org/7712001/diff/5001/chrome/browser/ui/gtk/gtk_ut...
File chrome/browser/ui/gtk/gtk_util_unittest.cc (right):

http://codereview.chromium.org/7712001/diff/5001/chrome/browser/ui/gtk/gtk_ut...
chrome/browser/ui/gtk/gtk_util_unittest.cc:34: const int size = sizeof(states) /
sizeof(states[0]);
How about using arraysize or ARRAYSIZE_UNSAFE from base? Seems still safer and
more readable than writing it yourself.

http://codereview.chromium.org/7712001/diff/5001/chrome/browser/ui/gtk/gtk_ut...
chrome/browser/ui/gtk/gtk_util_unittest.cc:35: for (int i = 0; i < size; ++i) {
It would be nice to add SCOPED_TRACE here and below for better error messages.

[Elliot Glaysher, 2011-08-24 18:04:49]

Please don't make gtk files depend on views files.

http://codereview.chromium.org/7712001/diff/5001/chrome/browser/ui/gtk/bookma...
File chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc (right):

http://codereview.chromium.org/7712001/diff/5001/chrome/browser/ui/gtk/bookma...
chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc:19: #include
"chrome/browser/ui/views/event_utils.h"
Please move event_utils to a common location; this is a gtk file.

http://codereview.chromium.org/7712001/diff/5001/chrome/browser/ui/gtk/gtk_ut...
File chrome/browser/ui/gtk/gtk_util.cc (right):

http://codereview.chromium.org/7712001/diff/5001/chrome/browser/ui/gtk/gtk_ut...
chrome/browser/ui/gtk/gtk_util.cc:30: #include
"chrome/browser/ui/views/event_utils.h"
views in gtk

[shinyak (Google), 2011-08-25 05:54:10]

http://codereview.chromium.org/7712001/diff/5001/chrome/browser/ui/gtk/bookma...
File chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc (right):

http://codereview.chromium.org/7712001/diff/5001/chrome/browser/ui/gtk/bookma...
chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc:19: #include
"chrome/browser/ui/views/event_utils.h"
On 2011/08/24 18:04:49, Elliot Glaysher wrote:
> Please move event_utils to a common location; this is a gtk file.

Done.
just removed this header file because it is not necessary.

http://codereview.chromium.org/7712001/diff/5001/chrome/browser/ui/gtk/gtk_ut...
File chrome/browser/ui/gtk/gtk_util.cc (right):

http://codereview.chromium.org/7712001/diff/5001/chrome/browser/ui/gtk/gtk_ut...
chrome/browser/ui/gtk/gtk_util.cc:30: #include
"chrome/browser/ui/views/event_utils.h"
On 2011/08/24 18:04:49, Elliot Glaysher wrote:
> views in gtk

Done.

http://codereview.chromium.org/7712001/diff/5001/chrome/browser/ui/gtk/gtk_ut...
File chrome/browser/ui/gtk/gtk_util_unittest.cc (right):

http://codereview.chromium.org/7712001/diff/5001/chrome/browser/ui/gtk/gtk_ut...
chrome/browser/ui/gtk/gtk_util_unittest.cc:34: const int size = sizeof(states) /
sizeof(states[0]);
On 2011/08/24 17:15:01, Paweł Hajdan Jr. wrote:
> How about using arraysize or ARRAYSIZE_UNSAFE from base? Seems still safer and
> more readable than writing it yourself.

Done. used arraysize() instead.

http://codereview.chromium.org/7712001/diff/5001/chrome/browser/ui/gtk/gtk_ut...
chrome/browser/ui/gtk/gtk_util_unittest.cc:35: for (int i = 0; i < size; ++i) {
On 2011/08/24 17:15:01, Paweł Hajdan Jr. wrote:
> It would be nice to add SCOPED_TRACE here and below for better error messages.

Done.

[Elliot Glaysher, 2011-08-25 17:45:10]

lgtm

[shinyak (Google), 2011-08-29 08:14:53]

made a minor fix because this CL will break the build of the latest trunk.

[shinyak (Google), 2011-08-29 08:15:38]

In the Patch Set 6, this problem is fixed.

[commit-bot: I haz the power, 2011-08-30 04:30:28]

Can't process patch for file chrome/browser/event_disposition.cc.
A +