Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: chrome/browser/ui/views/event_utils.cc

Issue 7712001: WindowOpenDisposition should not be exposed in base and ui modules. (1) Gdk refactoring (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: minor fix. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/gtk/reload_button_gtk.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/event_utils.cc
diff --git a/chrome/browser/ui/views/event_utils.cc b/chrome/browser/ui/views/event_utils.cc
index 49d021398c32bf9b46812727c133705a83e1300a..f134f38f1253254392860902f3cb02d412605b82 100644
--- a/chrome/browser/ui/views/event_utils.cc
+++ b/chrome/browser/ui/views/event_utils.cc
@@ -3,7 +3,7 @@
// found in the LICENSE file.
#include "chrome/browser/ui/views/event_utils.h"
-
+#include "chrome/browser/event_disposition.h"
#include "content/browser/disposition_utils.h"
#include "views/events/event.h"
@@ -11,13 +11,9 @@ using views::Event;
namespace event_utils {
+// TODO(shinyak) After refactoring, this function shoulbe removed.
WindowOpenDisposition DispositionFromEventFlags(int event_flags) {
- return disposition_utils::DispositionFromClick(
- (event_flags & ui::EF_MIDDLE_BUTTON_DOWN) != 0,
- (event_flags & ui::EF_ALT_DOWN) != 0,
- (event_flags & ui::EF_CONTROL_DOWN) != 0,
- false /* meta_key */,
- (event_flags & ui::EF_SHIFT_DOWN) != 0);
+ return browser::DispositionFromEventFlags(event_flags);
}
bool IsPossibleDispositionEvent(const views::MouseEvent& event) {
« no previous file with comments | « chrome/browser/ui/gtk/reload_button_gtk.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698