chrome/browser/ui/gtk/reload_button_gtk.cc - Issue 7712001: WindowOpenDisposition should not be exposed in base and ui modules. (1) Gdk refactoring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/reload_button_gtk.cc

Issue 7712001: WindowOpenDisposition should not be exposed in base and ui modules. (1) Gdk refactoring (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: minor fix. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/gtk/reload_button_gtk.cc

diff --git a/chrome/browser/ui/gtk/reload_button_gtk.cc b/chrome/browser/ui/gtk/reload_button_gtk.cc

index 5daf4de9dd2f3277e18c869b34e133df82bcb08a..d6e2501bd706943fe8a70c569660f06b981073b2 100644

--- a/chrome/browser/ui/gtk/reload_button_gtk.cc

+++ b/chrome/browser/ui/gtk/reload_button_gtk.cc

@@ -172,7 +172,7 @@ void ReloadButtonGtk::OnClicked(GtkWidget* /* sender */) {

}

WindowOpenDisposition disposition =

- event_utils::DispositionFromEventFlags(modifier_state_uint);

+ event_utils::DispositionFromGdkState(modifier_state_uint);

if ((disposition == CURRENT_TAB) && location_bar_) {

// Forcibly reset the location bar, since otherwise it won't discard any

// ongoing user edits, since it doesn't realize this is a user-initiated

« no previous file with comments | « chrome/browser/ui/gtk/menu_gtk.cc ('k') | chrome/browser/ui/views/event_utils.cc » ('j') | no next file with comments »