WindowOpenDisposition should not be exposed in base and ui modules. (1) Gdk refactoring

chrome/browser/ui/gtk/gtk_util_unittest.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "gtk_util.h"
+#include "ui/base/events.h"
+#include "chrome/test/base/testing_browser_process_test.h"
+#include "chrome/test/base/testing_profile.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+static const guint states[] = {
+  GDK_LOCK_MASK,
+  GDK_CONTROL_MASK,
+  GDK_SHIFT_MASK,
+  GDK_MOD1_MASK,
+  GDK_BUTTON1_MASK,
+  GDK_BUTTON2_MASK,
+  GDK_BUTTON3_MASK
+};
+
+static const int flags[] = {
+  ui::EF_CAPS_LOCK_DOWN,
+  ui::EF_CONTROL_DOWN,
+  ui::EF_SHIFT_DOWN,
+  ui::EF_ALT_DOWN,
+  ui::EF_LEFT_BUTTON_DOWN,
+  ui::EF_MIDDLE_BUTTON_DOWN,
+  ui::EF_RIGHT_BUTTON_DOWN
+};
+
+typedef TestingBrowserProcessTest GTKUtilTest;
+
+TEST(GTKUtilTest, TestEventFlagsFromGdkState) {
+  const int size = sizeof(states) / sizeof(states[0]);

[Paweł Hajdan Jr., 2011/08/24 17:15:01]

How about using arraysize or ARRAYSIZE_UNSAFE from base? Seems still safer and
more readable than writing it yourself.

[shinyak (Google), 2011/08/25 05:54:10]

Done. used arraysize() instead.

+  for (int i = 0; i < size; ++i) {

[Paweł Hajdan Jr., 2011/08/24 17:15:01]

It would be nice to add SCOPED_TRACE here and below for better error messages.

[shinyak (Google), 2011/08/25 05:54:10]

Done.

+    EXPECT_EQ(flags[i], event_utils::EventFlagsFromGdkState(states[i]));
+  }
+
+  for (int i = 0; i < size; ++i) {
+    for (int j = i + 1; j < size; ++j) {
+      EXPECT_EQ(flags[i] | flags[j],
+                event_utils::EventFlagsFromGdkState(states[i] | states[j]));
+    }
+  }
+}