Issue 7601006: GTTF: Use a fresh TestingBrowserProcess for each test, part #5

Issue 7601006: GTTF: Use a fresh TestingBrowserProcess for each test, part #5 (Closed)

Created:
9 years, 4 months ago by Paweł Hajdan Jr.

Modified:
9 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, Erik does not do reviews, mihaip+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, Aaron Boodman, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, Paweł Hajdan Jr., ctguil+watch_chromium.org, zork+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

GTTF: Use a fresh TestingBrowserProcess for each test, part #5 For a detailed description see part #1, http://codereview.chromium.org/6478005/ This CL fixes the bug fully on Windows. More platforms will follow. BUG=61062 TEST=unit_tests, possibly more Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96269

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -36 lines)			Patch
M	chrome/browser/bookmarks/bookmark_node_data_unittest.cc	View	1 2 3 4 5 6 7	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/browsing_data_database_helper_browsertest.cc	View	1 2 3 4 5 6 7	6 chunks	+6 lines, -8 lines	0 comments	Download
M	chrome/browser/browsing_data_indexed_db_helper_browsertest.cc	View	1 2 3 4 5 6 7	4 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/browsing_data_local_storage_helper_browsertest.cc	View	1 2 3 4 5 6 7	6 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/extensions/extension_bookmarks_unittest.cc	View	1 2 3 4 5 6 7	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_cookies_unittest.cc	View	1 2 3 4 5 6 7	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_process_manager_unittest.cc	View	1 2 3 4 5 6 7	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/intents/web_intents_registry_unittest.cc	View	1 2 3 4 5 6 7	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/metrics/metrics_service_uitest.cc	View	1 2 3 4 5 6 7	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_win_unittest.cc	View	1 2 3 4 5 6 7	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/policy/enterprise_metrics_browsertest.cc	View	1 2 3 4 5 6 7	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/profiles/avatar_menu_model_unittest.cc	View	1 2 3 4 5 6 7	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/accessibility_event_router_views_unittest.cc	View	1 2 3 4 5 6 7	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_context_menu_test.cc	View	1 2 3 4 5 6 7	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc	View	1 2 3 4 5 6 7	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/extensions/browser_action_drag_data_unittest.cc	View	1 2 3 4 5 6 7	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4 5 6 7	4 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/test/base/chrome_test_suite.cc	View	1 2 3 4 5 6 7	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/test/base/in_process_browser_test.cc	View	1 2 3 4 5 6 7	2 chunks	+14 lines, -0 lines	0 comments	Download
M	chrome/test/testing_browser_process.cc	View	1 2 3 4 5 6 7	3 chunks	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages