Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: chrome/test/base/in_process_browser_test.cc

Issue 7601006: GTTF: Use a fresh TestingBrowserProcess for each test, part #5 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/chrome_test_suite.cc ('k') | chrome/test/testing_browser_process.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/in_process_browser_test.cc
===================================================================
--- chrome/test/base/in_process_browser_test.cc (revision 96265)
+++ chrome/test/base/in_process_browser_test.cc (working copy)
@@ -94,10 +94,17 @@
ASSERT_TRUE(CreateUserDataDirectory())
<< "Could not create user data directory.";
+#if defined(OS_WIN)
+ // This is not really Windows-specific, the transition is just being done
+ // in stages, and Windows is first. See below for more info.
+ DCHECK(!g_browser_process);
+#else
+ // TODO(phajdan.jr): Temporary, for http://crbug.com/61062.
// The unit test suite creates a testingbrowser, but we want the real thing.
// Delete the current one. We'll install the testing one in TearDown.
delete g_browser_process;
g_browser_process = NULL;
+#endif
// Allow subclasses the opportunity to make changes to the default user data
// dir before running any tests.
@@ -218,9 +225,16 @@
}
void InProcessBrowserTest::TearDown() {
+#if defined(OS_WIN)
+ // This is not really Windows-specific, the transition is just being done
+ // in stages, and Windows is first. See below for more info.
+ DCHECK(!g_browser_process);
+#else
+ // TODO(phajdan.jr): Temporary, for http://crbug.com/61062.
// Reinstall testing browser process.
delete g_browser_process;
g_browser_process = new TestingBrowserProcess();
+#endif
browser_shutdown::delete_resources_on_shutdown = true;
« no previous file with comments | « chrome/test/base/chrome_test_suite.cc ('k') | chrome/test/testing_browser_process.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698