GTTF: Use a fresh TestingBrowserProcess for each test, part #5

chrome/browser/browsing_data_local_storage_helper_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/callback.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/test/thread_test_helper.h"
 #include "chrome/browser/browsing_data_helper_browsertest.h"
 #include "chrome/browser/browsing_data_local_storage_helper.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/browser.h"
 #include "chrome/test/base/in_process_browser_test.h"
-#include "chrome/test/base/testing_profile.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/browser/in_process_webkit/webkit_context.h"
 #include "content/browser/in_process_webkit/webkit_thread.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 typedef
     BrowsingDataHelperCallback<BrowsingDataLocalStorageHelper::LocalStorageInfo>
     TestCompletionCallback;
 
@@ skipping 18 matching lines @@
     const FilePath::CharType* kFilesToCreate[] = {
         kTestFile0, kTestFile1, kTestFileInvalid, kTestFileExtension
     };
     for (size_t i = 0; i < arraysize(kFilesToCreate); ++i) {
       FilePath file_path = storage_path.Append(kFilesToCreate[i]);
       file_util::WriteFile(file_path, NULL, 0);
     }
   }
 
   FilePath GetLocalStoragePathForTestingProfile() {
-    FilePath storage_path(testing_profile_.GetPath());
+    FilePath storage_path(browser()->profile()->GetPath());
     storage_path = storage_path.Append(
         DOMStorageContext::kLocalStorageDirectory);
     return storage_path;
   }
-  TestingProfile testing_profile_;
 };
 
 // This class is notified by BrowsingDataLocalStorageHelper on the UI thread
 // once it finishes fetching the local storage data.
 class StopTestOnCallback {
  public:
   explicit StopTestOnCallback(
       BrowsingDataLocalStorageHelper* local_storage_helper)
       : local_storage_helper_(local_storage_helper) {
     DCHECK(local_storage_helper_);
@@ skipping 23 matching lines @@
     }
     MessageLoop::current()->Quit();
   }
 
  private:
   BrowsingDataLocalStorageHelper* local_storage_helper_;
 };
 
 IN_PROC_BROWSER_TEST_F(BrowsingDataLocalStorageHelperTest, CallbackCompletes) {
   scoped_refptr<BrowsingDataLocalStorageHelper> local_storage_helper(
-      new BrowsingDataLocalStorageHelper(&testing_profile_));
+      new BrowsingDataLocalStorageHelper(browser()->profile()));
   CreateLocalStorageFilesForTest();
   StopTestOnCallback stop_test_on_callback(local_storage_helper);
   local_storage_helper->StartFetching(
       NewCallback(&stop_test_on_callback, &StopTestOnCallback::Callback));
   // Blocks until StopTestOnCallback::Callback is notified.
   ui_test_utils::RunMessageLoop();
 }
 
 IN_PROC_BROWSER_TEST_F(BrowsingDataLocalStorageHelperTest, DeleteSingleFile) {
   scoped_refptr<BrowsingDataLocalStorageHelper> local_storage_helper(
-      new BrowsingDataLocalStorageHelper(&testing_profile_));
+      new BrowsingDataLocalStorageHelper(browser()->profile()));
   CreateLocalStorageFilesForTest();
   local_storage_helper->DeleteLocalStorageFile(
       GetLocalStoragePathForTestingProfile().Append(FilePath(kTestFile0)));
   scoped_refptr<base::ThreadTestHelper> wait_for_webkit_thread(
       new base::ThreadTestHelper(
           BrowserThread::GetMessageLoopProxyForThread(BrowserThread::WEBKIT)));
   ASSERT_TRUE(wait_for_webkit_thread->Run());
   // Ensure the file has been deleted.
   file_util::FileEnumerator file_enumerator(
       GetLocalStoragePathForTestingProfile(),
@@ skipping 12 matching lines @@
 IN_PROC_BROWSER_TEST_F(BrowsingDataLocalStorageHelperTest,
                        CannedAddLocalStorage) {
   const GURL origin1("http://host1:1/");
   const GURL origin2("http://host2:1/");
   const FilePath::CharType file1[] =
       FILE_PATH_LITERAL("http_host1_1.localstorage");
   const FilePath::CharType file2[] =
       FILE_PATH_LITERAL("http_host2_1.localstorage");
 
   scoped_refptr<CannedBrowsingDataLocalStorageHelper> helper(
-      new CannedBrowsingDataLocalStorageHelper(&testing_profile_));
+      new CannedBrowsingDataLocalStorageHelper(browser()->profile()));
   helper->AddLocalStorage(origin1);
   helper->AddLocalStorage(origin2);
 
   TestCompletionCallback callback;
   helper->StartFetching(
       NewCallback(&callback, &TestCompletionCallback::callback));
 
   std::vector<BrowsingDataLocalStorageHelper::LocalStorageInfo> result =
       callback.result();
 
   ASSERT_EQ(2u, result.size());
   EXPECT_EQ(FilePath(file1).value(), result[0].file_path.BaseName().value());
   EXPECT_EQ(FilePath(file2).value(), result[1].file_path.BaseName().value());
 }
 
 IN_PROC_BROWSER_TEST_F(BrowsingDataLocalStorageHelperTest, CannedUnique) {
   const GURL origin("http://host1:1/");
   const FilePath::CharType file[] =
       FILE_PATH_LITERAL("http_host1_1.localstorage");
 
   scoped_refptr<CannedBrowsingDataLocalStorageHelper> helper(
-      new CannedBrowsingDataLocalStorageHelper(&testing_profile_));
+      new CannedBrowsingDataLocalStorageHelper(browser()->profile()));
   helper->AddLocalStorage(origin);
   helper->AddLocalStorage(origin);
 
   TestCompletionCallback callback;
   helper->StartFetching(
       NewCallback(&callback, &TestCompletionCallback::callback));
 
   std::vector<BrowsingDataLocalStorageHelper::LocalStorageInfo> result =
       callback.result();
 
   ASSERT_EQ(1u, result.size());
   EXPECT_EQ(FilePath(file).value(), result[0].file_path.BaseName().value());
 }
 }  // namespace