|
GTTF: Use a fresh TestingBrowserProcess for each test, part #1
This is going to be done in multiple steps,
because lots of tests depend on global TestingBrowserProcess.
However, the current solution is very error-prone,
and may lead to state being carried from one test
to another (via NotificationService), resulting in crashes.
In theory the ScopedTestingBrowserProcess could be made
empty for now, but re-initializing g_browser_process inside it
has two benefits:
1) It verifies that changing g_browser_process actually works.
2) It protects at least a subset of tests from carrying state.
BUG= 61062
TEST=unit_tests, possibly more
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74926
Total comments: 7
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+127 lines, -19 lines) |
Patch |
|
M |
chrome/browser/app_controller_mac_unittest.mm
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/appcache/chrome_appcache_service_unittest.cc
|
View
|
1
2
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/autocomplete/autocomplete_edit_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/autocomplete/autocomplete_unittest.cc
|
View
|
1
|
6 chunks |
+11 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/autocomplete/history_contents_provider_unittest.cc
|
View
|
1
2
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/autocomplete/history_quick_provider_unittest.cc
|
View
|
1
2
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/autocomplete/history_url_provider_unittest.cc
|
View
|
1
2
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/autocomplete/keyword_provider_unittest.cc
|
View
|
1
2
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/autocomplete/search_provider_unittest.cc
|
View
|
1
2
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/autocomplete_history_manager_unittest.cc
|
View
|
1
2
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm
|
View
|
|
2 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/autofill/autofill_download_unittest.cc
|
View
|
1
|
3 chunks |
+6 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/autofill/autofill_manager_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/autofill/autofill_metrics_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/autofill/personal_data_manager_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/automation/automation_provider_unittest.cc
|
View
|
1
|
2 chunks |
+5 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/background_contents_service_unittest.cc
|
View
|
1
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/background_mode_manager_unittest.cc
|
View
|
1
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/background_page_tracker_unittest.cc
|
View
|
1
|
4 chunks |
+9 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_tests.gypi
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chrome/test/testing_browser_process.h
|
View
|
|
1 chunk |
+14 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/test/testing_browser_process.cc
|
View
|
|
1 chunk |
+23 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/test/testing_browser_process_test.h
|
View
|
1
|
1 chunk |
+18 lines, -0 lines |
0 comments
|
Download
|
Total messages: 6 (0 generated)
|