Code to package Cloud Print Linux and Mac virtual drivers.

Code to package Cloud Print Linux and Mac virtual drivers.
Copies the relevant to PRODUCTDIR/cloud_print_installer using the GYP file mechanism.
On Linux, then rolls the Debian package using dpkg-deb, called by build.sh.
Similarly, on Mac, creates a package installer.

BUG=NONE
TEST=gcp-driver.deb or GCP-virtual-driver.pkg is produced in PRODUCTDIR/cloud_print_installer

[abeera, 2011-08-09 20:28:29]

Right now, I just have a placeholder Copyright file . I'll update it once I find
the appropriate one.

[Scott Byer, 2011-08-17 20:51:36]

CC'ing in Nico for virtual_driver_posix_packaging.gyp, who can feel free to
forward it on to someone else with more gyp experience than I.

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/posix/linux_packaging/copyright (right):

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/linux_packaging/copyright:3: # found in the
LICENSE file.
Ah, this is the placeholder. Yeah, check with Tyler.

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/posix/linux_packaging/postinst (right):

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/linux_packaging/postinst:10: lpadmin -p
Google-Cloud-Print -E -P /usr/share/ppd/GCP/GCP-driver.ppd -D "Google Cloud
Print" -o printer-is-shared=false -v GCP-driver:/
nit: long line - use continuation and indent

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/linux_packaging/postinst:11: 
nit: extra line

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
File
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/01package-contents.xml
(right):

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/01package-contents.xml:1:
<pkg-contents spec="1.12"><f n="package_root" o="root" g="wheel" p="16877"
pt="/Users/abeera/chrome/src/cloud_print/virtual_driver/posix/mac_packaging/package_root"
m="true" t="file"><f n="usr" o="root" g="wheel" p="16877"><f n="libexec"
o="root" g="wheel" p="16877"><f n="cups" o="root" g="wheel" p="16877"><f
n="backend" o="root" g="wheel" p="16877"><f n="GCP-driver" o="root" g="wheel"
p="33216"><mod>group</mod><mod>mode</mod><mod>owner</mod></f><mod>group</mod><mod>owner</mod></f><mod>group</mod><mod>owner</mod></f><mod>group</mod><mod>owner</mod></f><mod>group</mod><mod>owner</mod></f><mod>group</mod><mod>owner</mod></f></pkg-contents>
reformat this to be readable.

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
File
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/01package.xml
(right):

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/01package.xml:1:
<pkgref spec="1.12"
uuid="F758B796-EDED-43C8-AC5E-4FA409309508"><config><identifier>com.google.CloudPrint.VirtualDriver</identifier><version>0.1</version><description></description><post-install
type="none"/><requireAuthorization/><installFrom relative="true"
mod="true">package_root</installFrom><installTo>/</installTo><flags><followSymbolicLinks/></flags><packageStore
type="internal"></packageStore><mod>scripts.preinstall.path</mod><mod>scripts.scriptsDirectoryPath.isRelativeType</mod><mod>installTo</mod><mod>scripts.postinstall.path</mod><mod>installTo.isRelativeType</mod><mod>installTo.isAbsoluteType</mod><mod>version</mod><mod>parent</mod><mod>scripts.scriptsDirectoryPath.path</mod><mod>scripts.preinstall.isRelativeType</mod><mod>identifier</mod><mod>installFrom.path</mod></config><scripts><postinstall
relative="true" mod="true">Resources/install.sh</postinstall><scripts-dir
relative="true"
mod="true">Resources</scripts-dir></scripts><contents><file-list>01package-contents.xml</file-list><filter>/CVS$</filter><filter>/\.svn$</filter><filter>/\.cvsignore$</filter><filter>/\.cvspass$</filter><filter>/\.DS_Store$</filter></contents></pkgref>
reformat this to be readable

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
File
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/index.xml
(right):

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/index.xml:1:
<pkmkdoc spec="1.12"><properties><title>Google Cloud Print Virtual
Driver</title><build>/Users/abeera/Desktop/aa.pkg</build><organization>com.google</organization><userSees
ui="easy"/><min-target os="2"/><domain
system="true"/></properties><distribution><versions
min-spec="1.000000"/><scripts></scripts></distribution><contents><choice
title="package_root" id="choice1" starts_selected="true" starts_enabled="true"
starts_hidden="false"><pkgref
id="com.google.CloudPrint.VirtualDriver"/></choice></contents><resources
bg-scale="none" bg-align="topleft"><locale lang="en"/></resources><flags/><item
type="file">01package.xml</item><mod>properties.title</mod><mod>properties.anywhereDomain</mod><mod>properties.systemDomain</mod></pkmkdoc>
reformat this to be readable

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/posix/mac_packaging/install.sh (right):

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/install.sh:12: sudo killall cupsd
I think you want to use launchd instead, to make sure that cupd gets started
with any command line args the local install may have changed:

sudo launchctl stop org.cups.cupsd
sudo launchctl start org.cups.cupsd

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/install.sh:21: "Google Cloud
Print" -u allow:$USER -o printer-is-shared=false -v GCP-driver:/
nit: indent continuation line

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/posix/mac_packaging/uninstall.sh (right):

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/uninstall.sh:14: killall cupsd
Use launchctl here as well.

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/uninstall.sh:16: cupsd
and here too

[abeera, 2011-08-18 16:36:25]

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/posix/linux_packaging/postinst (right):

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/linux_packaging/postinst:10: lpadmin -p
Google-Cloud-Print -E -P /usr/share/ppd/GCP/GCP-driver.ppd -D "Google Cloud
Print" -o printer-is-shared=false -v GCP-driver:/
On 2011/08/17 20:51:36, Scott Byer wrote:
> nit: long line - use continuation and indent

Done.

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/linux_packaging/postinst:11: 
On 2011/08/17 20:51:36, Scott Byer wrote:
> nit: extra line

Done.

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
File
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/01package-contents.xml
(right):

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/01package-contents.xml:1:
<pkg-contents spec="1.12"><f n="package_root" o="root" g="wheel" p="16877"
pt="/Users/abeera/chrome/src/cloud_print/virtual_driver/posix/mac_packaging/package_root"
m="true" t="file"><f n="usr" o="root" g="wheel" p="16877"><f n="libexec"
o="root" g="wheel" p="16877"><f n="cups" o="root" g="wheel" p="16877"><f
n="backend" o="root" g="wheel" p="16877"><f n="GCP-driver" o="root" g="wheel"
p="33216"><mod>group</mod><mod>mode</mod><mod>owner</mod></f><mod>group</mod><mod>owner</mod></f><mod>group</mod><mod>owner</mod></f><mod>group</mod><mod>owner</mod></f><mod>group</mod><mod>owner</mod></f><mod>group</mod><mod>owner</mod></f></pkg-contents>
On 2011/08/17 20:51:36, Scott Byer wrote:
> reformat this to be readable.

Done.

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
File
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/01package.xml
(right):

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/01package.xml:1:
<pkgref spec="1.12"
uuid="F758B796-EDED-43C8-AC5E-4FA409309508"><config><identifier>com.google.CloudPrint.VirtualDriver</identifier><version>0.1</version><description></description><post-install
type="none"/><requireAuthorization/><installFrom relative="true"
mod="true">package_root</installFrom><installTo>/</installTo><flags><followSymbolicLinks/></flags><packageStore
type="internal"></packageStore><mod>scripts.preinstall.path</mod><mod>scripts.scriptsDirectoryPath.isRelativeType</mod><mod>installTo</mod><mod>scripts.postinstall.path</mod><mod>installTo.isRelativeType</mod><mod>installTo.isAbsoluteType</mod><mod>version</mod><mod>parent</mod><mod>scripts.scriptsDirectoryPath.path</mod><mod>scripts.preinstall.isRelativeType</mod><mod>identifier</mod><mod>installFrom.path</mod></config><scripts><postinstall
relative="true" mod="true">Resources/install.sh</postinstall><scripts-dir
relative="true"
mod="true">Resources</scripts-dir></scripts><contents><file-list>01package-contents.xml</file-list><filter>/CVS$</filter><filter>/\.svn$</filter><filter>/\.cvsignore$</filter><filter>/\.cvspass$</filter><filter>/\.DS_Store$</filter></contents></pkgref>
On 2011/08/17 20:51:36, Scott Byer wrote:
> reformat this to be readable

Done.

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
File
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/index.xml
(right):

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/index.xml:1:
<pkmkdoc spec="1.12"><properties><title>Google Cloud Print Virtual
Driver</title><build>/Users/abeera/Desktop/aa.pkg</build><organization>com.google</organization><userSees
ui="easy"/><min-target os="2"/><domain
system="true"/></properties><distribution><versions
min-spec="1.000000"/><scripts></scripts></distribution><contents><choice
title="package_root" id="choice1" starts_selected="true" starts_enabled="true"
starts_hidden="false"><pkgref
id="com.google.CloudPrint.VirtualDriver"/></choice></contents><resources
bg-scale="none" bg-align="topleft"><locale lang="en"/></resources><flags/><item
type="file">01package.xml</item><mod>properties.title</mod><mod>properties.anywhereDomain</mod><mod>properties.systemDomain</mod></pkmkdoc>
On 2011/08/17 20:51:36, Scott Byer wrote:
> reformat this to be readable

Done.

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/posix/mac_packaging/install.sh (right):

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/install.sh:12: sudo killall cupsd
On 2011/08/17 20:51:36, Scott Byer wrote:
> I think you want to use launchd instead, to make sure that cupd gets started
> with any command line args the local install may have changed:
> 
> sudo launchctl stop org.cups.cupsd
> sudo launchctl start org.cups.cupsd

Done.

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/install.sh:21: "Google Cloud
Print" -u allow:$USER -o printer-is-shared=false -v GCP-driver:/
On 2011/08/17 20:51:36, Scott Byer wrote:
> nit: indent continuation line

Done.

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/posix/mac_packaging/uninstall.sh (right):

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/uninstall.sh:14: killall cupsd
On 2011/08/17 20:51:36, Scott Byer wrote:
> Use launchctl here as well.

Done.

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/uninstall.sh:16: cupsd
On 2011/08/17 20:51:36, Scott Byer wrote:
> and here too

Done.

[abeera, 2011-08-18 19:16:42]

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/posix/linux_packaging/copyright (right):

http://codereview.chromium.org/7599018/diff/11001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/linux_packaging/copyright:3: # found in the
LICENSE file.
On 2011/08/17 20:51:36, Scott Byer wrote:
> Ah, this is the placeholder. Yeah, check with Tyler.

Done.

[abeera, 2011-08-19 15:33:43]

Today's actually my last day, so it'd be great if you could take a look. Thanks.

[Nico, 2011-08-19 15:41:25]

I was mostly waiting on Scott to LG the non-gyp files. Now that I looked at it,
Mark is a better reviewer for the gyp file (I never dealt with installers).

http://codereview.chromium.org/7599018/diff/19002/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/posix/virtual_driver_posix_packaging.gyp
(right):

http://codereview.chromium.org/7599018/diff/19002/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/virtual_driver_posix_packaging.gyp:7:
'INSTALLER_DIR' : '<(PRODUCT_DIR)/cloud_print_installer',
why upper case? aren't most variables lower case?

http://codereview.chromium.org/7599018/diff/19002/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/virtual_driver_posix_packaging.gyp:72: {
{ or } indentation is off here

[Mark Mentovai, 2011-08-19 15:54:18]

i’m not positive I’ll be able to do a big review like this on such short notice.

[abeera, 2011-08-19 21:12:19]

http://codereview.chromium.org/7599018/diff/19002/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/posix/virtual_driver_posix_packaging.gyp
(right):

http://codereview.chromium.org/7599018/diff/19002/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/virtual_driver_posix_packaging.gyp:7:
'INSTALLER_DIR' : '<(PRODUCT_DIR)/cloud_print_installer',
In the other GYP files I looked, variables used as part of a path seemed to be
in upper case.
On 2011/08/19 15:41:25, Nico wrote:
> why upper case? aren't most variables lower case?

http://codereview.chromium.org/7599018/diff/19002/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/virtual_driver_posix_packaging.gyp:72: {
On 2011/08/19 15:41:25, Nico wrote:
> { or } indentation is off here

Done.

[Mark Mentovai, 2011-08-19 23:52:20]

I hope my review came in time for you. This still needs work and needs to have
some questions answered.

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
File
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/01package-contents.xml
(right):

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/01package-contents.xml:3:
<f n="package_root" o="root" g="wheel" p="16877"
pt="/Users/abeera/chrome/src/cloud_print/virtual_driver/posix/mac_packaging/package_root"
m="true" t="file">
16877 = 040755. That’s good.

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/01package-contents.xml:3:
<f n="package_root" o="root" g="wheel" p="16877"
pt="/Users/abeera/chrome/src/cloud_print/virtual_driver/posix/mac_packaging/package_root"
m="true" t="file">
Why is your home directory here? What happens if someone not named abeera tries
to use this?

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/01package-contents.xml:8:
<f n="GCP-driver" o="root" g="wheel" p="33216">
33216 = 0100700. Why are the group and other bits clear?

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/01package-contents.xml:28:
</pkg-contents>
Can you tell us how you created these files?

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
File
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/index.xml
(right):

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/index.xml:5:
<build>/Users/abeera/Desktop/aa.pkg</build>
Again with the home directory. And what’s aa.pkg?

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/posix/mac_packaging/install.sh (right):

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/install.sh:1: #!/bin/bash
What user does this script run as? root, right? That means we need to really
really really scrutinize it. There are some tricks you can use to keep yourself
safer when running a script a root. keystone_install.sh is an example.

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/install.sh:2: 
Boilerplate license. See chrome/installer/mac/keystone_install.sh for an
example.

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/install.sh:3: # Change working
directory to the one in which the script is located.
All shell scripts should run with set -e (unless proven unnecessary) so that
they exit immediately upon failure of any command.

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/install.sh:5: cd $DIR
These two lines are silly. Just do:

cd "$(dirname "${0}")"

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/install.sh:9: chmod 0700
/usr/libexec/cups/backend/GCP-driver
Why 0700?

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/install.sh:20: lpadmin -p
Google-Cloud-Print-$USER -E -P GCP-driver.ppd -D \
Use ${USER} form and always "quote" shell arguments.

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/install.sh:20: lpadmin -p
Google-Cloud-Print-$USER -E -P GCP-driver.ppd -D \
This only creates it for one user. How will other users on the system get their
own virtual driver instances?

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/install.sh:24: ./GCP-install
I would prefer to see

"$(pwd)/GCP-install"

so that ps output is more useful.

This also runs as root, right? Where’s the source? Can’t be too careful…

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/posix/mac_packaging/uninstall.sh (right):

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/uninstall.sh:1: #!/bin/bash
Similar comments to the other script apply.

I assume the other one is launched from the installer. Who launches this one?
Where’s it live?

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/posix/virtual_driver_posix_packaging.gyp
(right):

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/virtual_driver_posix_packaging.gyp:7:
'INSTALLER_DIR' : '<(PRODUCT_DIR)/cloud_print_installer',
installer_dir, lowercase. UPPERCASE_NAMES are reserved by GYP.

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/virtual_driver_posix_packaging.gyp:30:
'packaging_files_mac': [
Go through this file and fix the indentation throughout. We should be using a
simple two-space indent per [ or {, except that the [ and { are permitted to be
on the same line and cause only one level of indentation in the case of
conditions as on line 56, with the closing }] on one line as on line 62.

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/virtual_driver_posix_packaging.gyp:40:
'moved_packaging_files_mac': [
What are “packaging files” compared to “moved packaging files?”

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/virtual_driver_posix_packaging.gyp:66:
'destination': '<(INSTALLER_DIR)/',
No trailing slash necessary

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/virtual_driver_posix_packaging.gyp:101: # Local
Variables:
We don’t do this anymore. Take this block out.

[Mark Mentovai, 2011-08-19 23:56:23]

Note for review: consider
cloud_print/virtual_driver/posix/mac_packaging/build_mac.sh and
cloud_print/virtual_driver/posix/linux_packaging/build.sh as well. They were
originally part of this change.

[abeera_chromium.org, 2011-08-20 02:37:12]

Thank you for your quick response. Unfortunately, I'd left the office and I
don't have access to dev machines anymore. However, I've tried to respond where
I can.

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
File
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/01package-contents.xml
(right):

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/01package-contents.xml:3:
<f n="package_root" o="root" g="wheel" p="16877"
pt="/Users/abeera/chrome/src/cloud_print/virtual_driver/posix/mac_packaging/package_root"
m="true" t="file">
That's an error, I should have caught that earlier. I've emailed my mentors with
possible fixes. 
On 2011/08/19 23:52:20, Mark Mentovai wrote:
> Why is your home directory here? What happens if someone not named abeera
tries
> to use this?

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/01package-contents.xml:8:
<f n="GCP-driver" o="root" g="wheel" p="33216">
We want to run the CUPS backend GCP-driver as root. Setting the permissions in
this way allows that.
On 2011/08/19 23:52:20, Mark Mentovai wrote:
> 33216 = 0100700. Why are the group and other bits clear?

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/01package-contents.xml:28:
</pkg-contents>
I created them using Mac package maker: the pmdoc file can be opened in the
packagemaker GUI on Mac.
On 2011/08/19 23:52:20, Mark Mentovai wrote:
> Can you tell us how you created these files?

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
File
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/index.xml
(right):

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/index.xml:5:
<build>/Users/abeera/Desktop/aa.pkg</build>
This field is ignored when we build on the command line with the -t flag, as in
build_mac.sh. However, It can be fixed in the same way as the other location.
On 2011/08/19 23:52:20, Mark Mentovai wrote:
> Again with the home directory. And what’s aa.pkg?

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/posix/mac_packaging/install.sh (right):

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/install.sh:9: chmod 0700
/usr/libexec/cups/backend/GCP-driver
We need the permissions to be set this way, so that CUPS runs the program as
root,
On 2011/08/19 23:52:20, Mark Mentovai wrote:
> Why 0700?

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/install.sh:20: lpadmin -p
Google-Cloud-Print-$USER -E -P GCP-driver.ppd -D \

We only want to install per user, since GCP-install only installs for the
current user. Other users will have to run the installation process again. 
On 2011/08/19 23:52:20, Mark Mentovai wrote:
> This only creates it for one user. How will other users on the system get
their
> own virtual driver instances?

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/install.sh:24: ./GCP-install
Its a file that I wrote, part of the Chromium project, checked in earlier in
http://codereview.chromium.org/7485011/

On 2011/08/19 23:52:20, Mark Mentovai wrote:
> I would prefer to see
> 
> "$(pwd)/GCP-install"
> 
> so that ps output is more useful.
> 
> This also runs as root, right? Where’s the source? Can’t be too careful…

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/posix/mac_packaging/uninstall.sh (right):

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/mac_packaging/uninstall.sh:1: #!/bin/bash
I did not have sufficient time to build a complete uninstaller. This is just a
temporary script.
On 2011/08/19 23:52:20, Mark Mentovai wrote:
> Similar comments to the other script apply.
> 
> I assume the other one is launched from the installer. Who launches this one?
> Where’s it live?

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/posix/virtual_driver_posix_packaging.gyp
(right):

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/virtual_driver_posix_packaging.gyp:7:
'INSTALLER_DIR' : '<(PRODUCT_DIR)/cloud_print_installer',
Ah, thank you for clearing that up. All the path variables in the file I
referenced were uppercase, so I just assumed that to be the convention.
On 2011/08/19 23:52:20, Mark Mentovai wrote:
> installer_dir, lowercase. UPPERCASE_NAMES are reserved by GYP.

http://codereview.chromium.org/7599018/diff/24001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/posix/virtual_driver_posix_packaging.gyp:40:
'moved_packaging_files_mac': [
Packaging files are the files at their original location, moved packaging files
are the files that have been copied over to the staging directory.
On 2011/08/19 23:52:20, Mark Mentovai wrote:
> What are “packaging files” compared to “moved packaging files?”