Code to package Cloud Print Linux and Mac virtual drivers.

cloud_print/virtual_driver/posix/virtual_driver_posix_packaging.gyp

+# Copyright (c) 2011 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+{
+  'variables': {
+     'chromium_code': 1,
+     'INSTALLER_DIR' : '<(PRODUCT_DIR)/cloud_print_installer',

[Mark Mentovai, 2011/08/19 23:52:20]

installer_dir, lowercase. UPPERCASE_NAMES are reserved by GYP.

[abeera_chromium.org, 2011/08/20 02:37:13]

Ah, thank you for clearing that up. All the path variables in the file I
referenced were uppercase, so I just assumed that to be the convention.
On 2011/08/19 23:52:20, Mark Mentovai wrote:

+     'packaging_files_linux': [
+        '../GCP-driver.ppd',
+        '<(PRODUCT_DIR)/GCP-driver',
+        'linux_packaging/build.sh',
+        'linux_packaging/control',
+        'linux_packaging/copyright',
+        'linux_packaging/changelog',
+        'linux_packaging/postinst',
+        'linux_packaging/postrm',
+        'linux_packaging/prerm',
+     ],
+     'moved_packaging_files_linux': [
+        '<(INSTALLER_DIR)/GCP-driver',
+        '<(INSTALLER_DIR)/build.sh',
+        '<(INSTALLER_DIR)/control',
+        '<(INSTALLER_DIR)/copyright',
+        '<(INSTALLER_DIR)/changelog',
+        '<(INSTALLER_DIR)/GCP-driver.ppd',
+        '<(INSTALLER_DIR)/postinst',
+        '<(INSTALLER_DIR)/postrm',
+        '<(INSTALLER_DIR)/prerm',
+     ],
+   'packaging_files_mac': [

[Mark Mentovai, 2011/08/19 23:52:20]

Go through this file and fix the indentation throughout. We should be using a
simple two-space indent per [ or {, except that the [ and { are permitted to be
on the same line and cause only one level of indentation in the case of
conditions as on line 56, with the closing }] on one line as on line 62.

+        '<(PRODUCT_DIR)/GCP-driver',
+        '<(PRODUCT_DIR)/GCP-install',
+        '<(PRODUCT_DIR)/GCP-uninstall',
+        'mac_packaging/install.sh',
+        'mac_packaging/build_mac.sh',
+        'mac_packaging/GCP-Virtual-Driver.pmdoc',
+        '../GCP-driver.ppd',
+        'mac_packaging/uninstall.sh',
+      ],
+  'moved_packaging_files_mac': [

[Mark Mentovai, 2011/08/19 23:52:20]

What are “packaging files” compared to “moved packaging files?”

[abeera_chromium.org, 2011/08/20 02:37:13]

Packaging files are the files at their original location, moved packaging files
are the files that have been copied over to the staging directory.
On 2011/08/19 23:52:20, Mark Mentovai wrote:

+        '<(INSTALLER_DIR)/GCP-driver',
+        '<(INSTALLER_DIR)/GCP-install',
+        '<(INSTALLER_DIR)/GCP-uninstall',
+        '<(INSTALLER_DIR)/install.sh',
+        '<(INSTALLER_DIR)/build_mac.sh',
+        '<(INSTALLER_DIR)/GCP-Virtual-Driver.pmdoc',
+        '<(INSTALLER_DIR)/GCP-driver.ppd',
+        '<(PRODUCT_DIR)/uninstall.sh',
+      ],
+   }, 
+   'targets': [
+      {
+        'target_name': 'cloud_print_installer_files',
+        'type': 'none',
+        'conditions': [
+          ['OS == "linux"', {
+            'copies': [
+            {
+              'destination': '<(INSTALLER_DIR)',
+              'files': ['<@(packaging_files_linux)']
+            }],
+          }],
+          ['OS == "mac"', {
+            'copies': [
+            {
+              'destination': '<(INSTALLER_DIR)/',

[Mark Mentovai, 2011/08/19 23:52:20]

No trailing slash necessary

+              'files': ['<@(packaging_files_mac)']
+            }],
+          }],
+        ],
+      },
+      {
+      'target_name': 'cloud_print_installer',
+      'type': 'none',
+      'dependencies': ['cloud_print_installer_files'],
+      'conditions': [
+          ['OS == "linux"', {
+            'actions': [
+            {
+              'action_name':'cloud_print_deb_pack',
+              'inputs': ['<@(moved_packaging_files_linux)'],
+              'action': ['<(INSTALLER_DIR)/build.sh'],
+              'outputs':['<(INSTALLER_DIR)/gcp-driver.deb']
+            }],
+          }],
+          ['OS == "mac"', {
+            'actions': [
+            {
+              'action_name':'cloud_print_mac_pack',
+              'inputs': ['<@(moved_packaging_files_mac)'],
+              'action': ['<(INSTALLER_DIR)/build_mac.sh'],
+              'outputs':[
+                '<(INSTALLER_DIR)/GCP-virtual-driver.pkg']
+            }],
+          }],
+      ],
+    },
+    ],
+}
+
+# Local Variables:

[Mark Mentovai, 2011/08/19 23:52:20]

We don’t do this anymore. Take this block out.

+# tab-width:2
+# indent-tabs-mode:nil
+# End:
+# vim: set expandtab tabstop=2 shiftwidth=2: