Code to package Cloud Print Linux and Mac virtual drivers.

cloud_print/virtual_driver/posix/mac_packaging/install.sh

Index: cloud_print/virtual_driver/posix/mac_packaging/install.sh
diff --git a/cloud_print/virtual_driver/posix/mac_packaging/install.sh b/cloud_print/virtual_driver/posix/mac_packaging/install.sh
new file mode 100755
index 0000000000000000000000000000000000000000..bc72247b6653956b42f772bd5185781864990e1f
--- /dev/null
+++ b/cloud_print/virtual_driver/posix/mac_packaging/install.sh
@@ -0,0 +1,24 @@
+#!/bin/bash

[Mark Mentovai, 2011/08/19 23:52:20]

What user does this script run as? root, right? That means we need to really
really really scrutinize it. There are some tricks you can use to keep yourself
safer when running a script a root. keystone_install.sh is an example.

+

[Mark Mentovai, 2011/08/19 23:52:20]

Boilerplate license. See chrome/installer/mac/keystone_install.sh for an
example.

+# Change working directory to the one in which the script is located.

[Mark Mentovai, 2011/08/19 23:52:20]

All shell scripts should run with set -e (unless proven unnecessary) so that
they exit immediately upon failure of any command.

+DIR="$( cd "$( dirname "$0" )" && pwd )"
+cd $DIR

[Mark Mentovai, 2011/08/19 23:52:20]

These two lines are silly. Just do:

cd "$(dirname "${0}")"

+
+# Change the ownership and permissions, as Package Maker can be buggy
+chown root:wheel /usr/libexec/cups/backend/GCP-driver
+chmod 0700 /usr/libexec/cups/backend/GCP-driver

[Mark Mentovai, 2011/08/19 23:52:20]

Why 0700?

[abeera_chromium.org, 2011/08/20 02:37:13]

We need the permissions to be set this way, so that CUPS runs the program as
root,
On 2011/08/19 23:52:20, Mark Mentovai wrote:

+
+# Restart cups so that it sees the new backend
+launchctl stop org.cups.cupsd
+launchctl start org.cups.cupsd
+
+# Install the Cloud Print Driver only for the current user,
+# since the Service Process is available only for current user
+# Give it a unique name, so that multiple users
+# on the same machine can install GCP.
+# $USER contains the username of the person that started the install.
+lpadmin -p Google-Cloud-Print-$USER -E -P GCP-driver.ppd -D \

[Mark Mentovai, 2011/08/19 23:52:20]

Use ${USER} form and always "quote" shell arguments.

[Mark Mentovai, 2011/08/19 23:52:20]

This only creates it for one user. How will other users on the system get their
own virtual driver instances?

[abeera_chromium.org, 2011/08/20 02:37:13]

We only want to install per user, since GCP-install only installs for the
current user. Other users will have to run the installation process again. 
On 2011/08/19 23:52:20, Mark Mentovai wrote:

+  "Google Cloud Print" -u allow:$USER -o printer-is-shared=false -v GCP-driver:/
+
+# Register the driver with Chrome/Chromium using the included ObjC program.
+./GCP-install

[Mark Mentovai, 2011/08/19 23:52:20]

I would prefer to see

"$(pwd)/GCP-install"

so that ps output is more useful.

This also runs as root, right? Where’s the source? Can’t be too careful…

[abeera_chromium.org, 2011/08/20 02:37:13]

Its a file that I wrote, part of the Chromium project, checked in earlier in
http://codereview.chromium.org/7485011/

On 2011/08/19 23:52:20, Mark Mentovai wrote: