cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/01package-contents.xml - Issue 7599018: Code to package Cloud Print Linux and Mac virtual drivers.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/01package-contents.xml

Issue 7599018: Code to package Cloud Print Linux and Mac virtual drivers. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Style fix. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/01package.xml ('k') | cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/index.xml » ('j') | cloud_print/virtual_driver/posix/mac_packaging/GCP-Virtual-Driver.pmdoc/index.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0"?>

	2 <pkg-contents spec="1.12">

	3 <f n="package_root" o="root" g="wheel" p="16877" pt="/Users/abeera/chrome/src/ cloud_print/virtual_driver/posix/mac_packaging/package_root" m="true" t="file">
	Mark Mentovai 2011/08/19 23:52:20 16877 = 040755. That’s good. 16877 = 040755. That’s good. Mark Mentovai 2011/08/19 23:52:20 Why is your home directory here? What happens if s Why is your home directory here? What happens if someone not named abeera tries to use this? abeera_chromium.org 2011/08/20 02:37:13 That's an error, I should have caught that earlier That's an error, I should have caught that earlier. I've emailed my mentors with possible fixes. On 2011/08/19 23:52:20, Mark Mentovai wrote: Show quoted text > Why is your home directory here? What happens if someone not named abeera tries > to use this?
	4 <f n="usr" o="root" g="wheel" p="16877">

	5 <f n="libexec" o="root" g="wheel" p="16877">

	6 <f n="cups" o="root" g="wheel" p="16877">

	7 <f n="backend" o="root" g="wheel" p="16877">

	8 <f n="GCP-driver" o="root" g="wheel" p="33216">
	Mark Mentovai 2011/08/19 23:52:20 33216 = 0100700. Why are the group and other bits 33216 = 0100700. Why are the group and other bits clear? abeera_chromium.org 2011/08/20 02:37:13 We want to run the CUPS backend GCP-driver as root We want to run the CUPS backend GCP-driver as root. Setting the permissions in this way allows that. On 2011/08/19 23:52:20, Mark Mentovai wrote: Show quoted text > 33216 = 0100700. Why are the group and other bits clear?
	9 <mod>group</mod>

	10 <mod>mode</mod>

	11 <mod>owner</mod>

	12 </f>

	13 <mod>group</mod>

	14 <mod>owner</mod>

	15 </f>

	16 <mod>group</mod>

	17 <mod>owner</mod>

	18 </f>

	19 <mod>group</mod>

	20 <mod>owner</mod>

	21 </f>

	22 <mod>group</mod>

	23 <mod>owner</mod>

	24 </f>

	25 <mod>group</mod>

	26 <mod>owner</mod>

	27 </f>

	28 </pkg-contents>
	Mark Mentovai 2011/08/19 23:52:20 Can you tell us how you created these files? Can you tell us how you created these files? abeera_chromium.org 2011/08/20 02:37:13 I created them using Mac package maker: the pmdoc I created them using Mac package maker: the pmdoc file can be opened in the packagemaker GUI on Mac. On 2011/08/19 23:52:20, Mark Mentovai wrote: Show quoted text > Can you tell us how you created these files?
OLD	NEW