Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7484054: Migrate Pipeline & PipelineImpl to PipelineStatusCB. (Closed)

Created:
9 years, 5 months ago by acolwell GONE FROM CHROMIUM
Modified:
9 years, 4 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Paweł Hajdan Jr., acolwell+watch_chromium.org, annacc+watch_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)
Visibility:
Public.

Description

Migrate Pipeline & PipelineImpl to PipelineStatusCB. BUG=90214 TEST=PipelineImplTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96096

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix nits #

Patch Set 3 : Fix player_x11 & player_wtl #

Patch Set 4 : Updates needed because DataSourceFactory & DemuxerFactory patches were reverted. #

Total comments: 8

Patch Set 5 : Fix CR nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -213 lines) Patch
M media/base/mock_filters.h View 2 3 1 chunk +1 line, -2 lines 0 comments Download
M media/base/mock_filters.cc View 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M media/base/pipeline.h View 5 chunks +6 lines, -7 lines 0 comments Download
M media/base/pipeline_impl.h View 6 chunks +18 lines, -18 lines 0 comments Download
M media/base/pipeline_impl.cc View 1 2 3 13 chunks +35 lines, -40 lines 0 comments Download
M media/base/pipeline_impl_unittest.cc View 1 10 chunks +24 lines, -25 lines 0 comments Download
M media/base/pipeline_status.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/ffmpeg_demuxer.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 1 2 3 6 chunks +6 lines, -7 lines 0 comments Download
M media/filters/ffmpeg_demuxer_factory.cc View 1 2 3 4 3 chunks +20 lines, -29 lines 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 1 2 3 5 chunks +5 lines, -5 lines 0 comments Download
M media/tools/player_wtl/movie.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M media/tools/player_x11/player_x11.cc View 1 2 5 chunks +7 lines, -4 lines 0 comments Download
M webkit/glue/media/buffered_data_source.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/glue/media/buffered_data_source.cc View 1 2 3 10 chunks +16 lines, -20 lines 0 comments Download
M webkit/glue/media/buffered_data_source_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/media/simple_data_source.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/media/simple_data_source.cc View 1 2 3 6 chunks +11 lines, -12 lines 0 comments Download
M webkit/glue/media/simple_data_source_unittest.cc View 1 2 3 4 9 chunks +20 lines, -17 lines 0 comments Download
M webkit/glue/media/web_data_source.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/media/web_data_source_factory.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M webkit/glue/webmediaplayer_impl.cc View 1 2 3 3 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
acolwell GONE FROM CHROMIUM
9 years, 5 months ago (2011-07-23 00:28:43 UTC) #1
scherkus (not reviewing)
nice! LGTM w/ nits http://codereview.chromium.org/7484054/diff/1/media/base/pipeline_impl.cc File media/base/pipeline_impl.cc (right): http://codereview.chromium.org/7484054/diff/1/media/base/pipeline_impl.cc#newcode140 media/base/pipeline_impl.cc:140: NewRunnableMethod(this, &PipelineImpl::SeekTask, time, nit: fit ...
9 years, 5 months ago (2011-07-23 01:51:32 UTC) #2
scherkus (not reviewing)
nice! LGTM w/ nits
9 years, 5 months ago (2011-07-23 01:51:32 UTC) #3
acolwell GONE FROM CHROMIUM
http://codereview.chromium.org/7484054/diff/1/media/base/pipeline_impl.cc File media/base/pipeline_impl.cc (right): http://codereview.chromium.org/7484054/diff/1/media/base/pipeline_impl.cc#newcode140 media/base/pipeline_impl.cc:140: NewRunnableMethod(this, &PipelineImpl::SeekTask, time, On 2011/07/23 01:51:32, scherkus wrote: > ...
9 years, 5 months ago (2011-07-27 16:17:04 UTC) #4
acolwell GONE FROM CHROMIUM
Sending out for review again since rolling back the DataSourceFactory & DemuxerFactory callback migration effected ...
9 years, 4 months ago (2011-08-09 16:02:24 UTC) #5
scherkus (not reviewing)
LGTM w/ nits http://codereview.chromium.org/7484054/diff/8001/media/filters/ffmpeg_demuxer_factory.cc File media/filters/ffmpeg_demuxer_factory.cc (right): http://codereview.chromium.org/7484054/diff/8001/media/filters/ffmpeg_demuxer_factory.cc#newcode13 media/filters/ffmpeg_demuxer_factory.cc:13: const scoped_refptr<FFmpegDemuxer>& demuxer, indent http://codereview.chromium.org/7484054/diff/8001/media/filters/ffmpeg_demuxer_factory.cc#newcode17 media/filters/ffmpeg_demuxer_factory.cc:17: ...
9 years, 4 months ago (2011-08-09 20:10:20 UTC) #6
acolwell GONE FROM CHROMIUM
9 years, 4 months ago (2011-08-09 20:36:43 UTC) #7 
http://codereview.chromium.org/7484054/diff/8001/media/filters/ffmpeg_demuxer...
File media/filters/ffmpeg_demuxer_factory.cc (right):

http://codereview.chromium.org/7484054/diff/8001/media/filters/ffmpeg_demuxer...
media/filters/ffmpeg_demuxer_factory.cc:13: const scoped_refptr<FFmpegDemuxer>&
demuxer,
On 2011/08/09 20:10:20, scherkus wrote:
> indent

Done.

http://codereview.chromium.org/7484054/diff/8001/media/filters/ffmpeg_demuxer...
media/filters/ffmpeg_demuxer_factory.cc:17: callback->Run(status,
static_cast<Demuxer*>(NULL));
On 2011/08/09 20:10:20, scherkus wrote:
> nit: IIRC we don't need the static_cast
Unfortunately we do still need it here because BuildCallback is still an old
style callback. Once these get converted over again I can remove the cast.

http://codereview.chromium.org/7484054/diff/8001/media/filters/ffmpeg_demuxer...
media/filters/ffmpeg_demuxer_factory.cc:34: //
DataSource,Demuxer}Factory::BuildCallback are migrated to the new
On 2011/08/09 20:10:20, scherkus wrote:
> missing {
> 
> also just checking but haven't we migrated some of these?

Done. I did migrate them and then had to roll it all back. I'll attempt it again
soon.

http://codereview.chromium.org/7484054/diff/8001/webkit/glue/media/simple_dat...
File webkit/glue/media/simple_data_source_unittest.cc (right):

http://codereview.chromium.org/7484054/diff/8001/webkit/glue/media/simple_dat...
webkit/glue/media/simple_data_source_unittest.cc:221: bool wasCalled = false;
On 2011/08/09 20:10:20, scherkus wrote:
> woah this ain't java here mister
> 
> was_called

Done. Old habits die hard. :/

Powered by Google App Engine
This is Rietveld 408576698