Index: media/base/pipeline_impl.h |
diff --git a/media/base/pipeline_impl.h b/media/base/pipeline_impl.h |
index caf4e19f081709a4ace1b08c822a850e970136eb..3f2723f634cc817551ef2dce49f210637d9d8c6e 100644 |
--- a/media/base/pipeline_impl.h |
+++ b/media/base/pipeline_impl.h |
@@ -39,17 +39,17 @@ class PipelineStatusNotification { |
~PipelineStatusNotification(); |
// See class-level comment for usage. |
- media::PipelineStatusCallback* Callback(); |
- void Notify(media::PipelineStatus status); |
+ PipelineStatusCB Callback(); |
void Wait(); |
- media::PipelineStatus status(); |
+ PipelineStatus status(); |
private: |
+ void Notify(media::PipelineStatus status); |
+ |
base::Lock lock_; |
base::ConditionVariable cv_; |
media::PipelineStatus status_; |
bool notified_; |
- scoped_ptr<media::PipelineStatusCallback> callback_; |
DISALLOW_COPY_AND_ASSIGN(PipelineStatusNotification); |
}; |
@@ -96,15 +96,15 @@ class PipelineImpl : public Pipeline, public FilterHost { |
explicit PipelineImpl(MessageLoop* message_loop); |
// Pipeline implementation. |
- virtual void Init(PipelineStatusCallback* ended_callback, |
- PipelineStatusCallback* error_callback, |
- PipelineStatusCallback* network_callback); |
+ virtual void Init(const PipelineStatusCB& ended_callback, |
+ const PipelineStatusCB& error_callback, |
+ const PipelineStatusCB& network_callback); |
virtual bool Start(FilterCollection* filter_collection, |
const std::string& uri, |
- PipelineStatusCallback* start_callback); |
- virtual void Stop(PipelineStatusCallback* stop_callback); |
+ const PipelineStatusCB& start_callback); |
+ virtual void Stop(const PipelineStatusCB& stop_callback); |
virtual void Seek(base::TimeDelta time, |
- PipelineStatusCallback* seek_callback); |
+ const PipelineStatusCB& seek_callback); |
virtual bool IsRunning() const; |
virtual bool IsInitialized() const; |
virtual bool IsNetworkActive() const; |
@@ -222,7 +222,7 @@ class PipelineImpl : public Pipeline, public FilterHost { |
// message loop. |
void StartTask(FilterCollection* filter_collection, |
const std::string& url, |
- PipelineStatusCallback* start_callback); |
+ const PipelineStatusCB& start_callback); |
// InitializeTask() performs initialization in multiple passes. It is executed |
// as a result of calling Start() or InitializationComplete() that advances |
@@ -231,7 +231,7 @@ class PipelineImpl : public Pipeline, public FilterHost { |
void InitializeTask(); |
// Stops and destroys all filters, placing the pipeline in the kStopped state. |
- void StopTask(PipelineStatusCallback* stop_callback); |
+ void StopTask(const PipelineStatusCB& stop_callback); |
// Carries out stopping and destroying all filters, placing the pipeline in |
// the kError state. |
@@ -250,7 +250,7 @@ class PipelineImpl : public Pipeline, public FilterHost { |
void PreloadChangedTask(Preload preload); |
// Carries out notifying filters that we are seeking to a new timestamp. |
- void SeekTask(base::TimeDelta time, PipelineStatusCallback* seek_callback); |
+ void SeekTask(base::TimeDelta time, const PipelineStatusCB& seek_callback); |
// Carries out handling a notification from a filter that it has ended. |
void NotifyEndedTask(); |
@@ -429,11 +429,11 @@ class PipelineImpl : public Pipeline, public FilterHost { |
std::string url_; |
// Callbacks for various pipeline operations. |
- scoped_ptr<PipelineStatusCallback> seek_callback_; |
- scoped_ptr<PipelineStatusCallback> stop_callback_; |
- scoped_ptr<PipelineStatusCallback> ended_callback_; |
- scoped_ptr<PipelineStatusCallback> error_callback_; |
- scoped_ptr<PipelineStatusCallback> network_callback_; |
+ PipelineStatusCB seek_callback_; |
+ PipelineStatusCB stop_callback_; |
+ PipelineStatusCB ended_callback_; |
+ PipelineStatusCB error_callback_; |
+ PipelineStatusCB network_callback_; |
// Reference to the filter(s) that constitute the pipeline. |
scoped_refptr<Filter> pipeline_filter_; |