Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: webkit/glue/media/simple_data_source.cc

Issue 7484054: Migrate Pipeline & PipelineImpl to PipelineStatusCB. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix CR nits Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/media/simple_data_source.h ('k') | webkit/glue/media/simple_data_source_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/media/simple_data_source.cc
diff --git a/webkit/glue/media/simple_data_source.cc b/webkit/glue/media/simple_data_source.cc
index 48c2044c2a5aae720d4fb3fdab3c0a5cec87d60d..8ad661b78433eb6965b27795c4618e35b7ab37fd 100644
--- a/webkit/glue/media/simple_data_source.cc
+++ b/webkit/glue/media/simple_data_source.cc
@@ -80,17 +80,17 @@ void SimpleDataSource::Stop(media::FilterCallback* callback) {
void SimpleDataSource::Initialize(
const std::string& url,
- media::PipelineStatusCallback* callback) {
- // Reference to prevent destruction while inside the |initialize_callback_|
+ const media::PipelineStatusCB& callback) {
+ // Reference to prevent destruction while inside the |initialize_cb_|
// call. This is a temporary fix to prevent crashes caused by holding the
// lock and running the destructor.
scoped_refptr<SimpleDataSource> destruction_guard(this);
{
base::AutoLock auto_lock(lock_);
DCHECK_EQ(state_, UNINITIALIZED);
- DCHECK(callback);
+ DCHECK(!callback.is_null());
state_ = INITIALIZING;
- initialize_callback_.reset(callback);
+ initialize_cb_ = callback;
// Validate the URL.
url_ = GURL(url);
@@ -107,9 +107,9 @@ void SimpleDataSource::Initialize(
void SimpleDataSource::CancelInitialize() {
base::AutoLock auto_lock(lock_);
- DCHECK(initialize_callback_.get());
+ DCHECK(!initialize_cb_.is_null());
state_ = STOPPED;
- initialize_callback_.reset();
+ initialize_cb_.Reset();
// Post a task to the render thread to cancel loading the resource.
render_loop_->PostTask(FROM_HERE,
@@ -202,7 +202,7 @@ void SimpleDataSource::didFinishLoading(
WebKit::WebURLLoader* loader,
double finishTime) {
DCHECK(MessageLoop::current() == render_loop_);
- // Reference to prevent destruction while inside the |initialize_callback_|
+ // Reference to prevent destruction while inside the |initialize_cb_|
// call. This is a temporary fix to prevent crashes caused by holding the
// lock and running the destructor.
scoped_refptr<SimpleDataSource> destruction_guard(this);
@@ -230,7 +230,7 @@ void SimpleDataSource::didFail(
WebKit::WebURLLoader* loader,
const WebKit::WebURLError& error) {
DCHECK(MessageLoop::current() == render_loop_);
- // Reference to prevent destruction while inside the |initialize_callback_|
+ // Reference to prevent destruction while inside the |initialize_cb_|
// call. This is a temporary fix to prevent crashes caused by holding the
// lock and running the destructor.
scoped_refptr<SimpleDataSource> destruction_guard(this);
@@ -266,7 +266,7 @@ void SimpleDataSource::Abort() {
void SimpleDataSource::StartTask() {
DCHECK(MessageLoop::current() == render_loop_);
- // Reference to prevent destruction while inside the |initialize_callback_|
+ // Reference to prevent destruction while inside the |initialize_cb_|
// call. This is a temporary fix to prevent crashes caused by holding the
// lock and running the destructor.
scoped_refptr<SimpleDataSource> destruction_guard(this);
@@ -341,9 +341,8 @@ void SimpleDataSource::DoneInitialization_Locked(bool success) {
url_loader_.reset();
}
- scoped_ptr<media::PipelineStatusCallback> initialize_callback(
- initialize_callback_.release());
- initialize_callback->Run(status);
+ initialize_cb_.Run(status);
+ initialize_cb_.Reset();
}
void SimpleDataSource::UpdateHostState() {
« no previous file with comments | « webkit/glue/media/simple_data_source.h ('k') | webkit/glue/media/simple_data_source_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698