Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: media/filters/ffmpeg_demuxer.cc

Issue 7484054: Migrate Pipeline & PipelineImpl to PipelineStatusCB. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix CR nits Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/ffmpeg_demuxer.h ('k') | media/filters/ffmpeg_demuxer_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/ffmpeg_demuxer.cc
diff --git a/media/filters/ffmpeg_demuxer.cc b/media/filters/ffmpeg_demuxer.cc
index e699a77af436fa1119c8cd207bb97e26bfe0a2c1..364a08f112f71a0573558f5b93182b2f5fe12d57 100644
--- a/media/filters/ffmpeg_demuxer.cc
+++ b/media/filters/ffmpeg_demuxer.cc
@@ -331,7 +331,7 @@ void FFmpegDemuxer::set_host(FilterHost* filter_host) {
}
void FFmpegDemuxer::Initialize(DataSource* data_source,
- PipelineStatusCallback* callback) {
+ const PipelineStatusCB& callback) {
message_loop_->PostTask(
FROM_HERE,
NewRunnableMethod(this,
@@ -426,9 +426,8 @@ MessageLoop* FFmpegDemuxer::message_loop() {
}
void FFmpegDemuxer::InitializeTask(DataSource* data_source,
- PipelineStatusCallback* callback) {
+ const PipelineStatusCB& callback) {
DCHECK_EQ(MessageLoop::current(), message_loop_);
- scoped_ptr<PipelineStatusCallback> callback_deleter(callback);
data_source_ = data_source;
if (host())
@@ -446,7 +445,7 @@ void FFmpegDemuxer::InitializeTask(DataSource* data_source,
FFmpegGlue::GetInstance()->RemoveProtocol(this);
if (result < 0) {
- callback->Run(DEMUXER_ERROR_COULD_NOT_OPEN);
+ callback.Run(DEMUXER_ERROR_COULD_NOT_OPEN);
return;
}
@@ -456,7 +455,7 @@ void FFmpegDemuxer::InitializeTask(DataSource* data_source,
// Fully initialize AVFormatContext by parsing the stream a little.
result = av_find_stream_info(format_context_);
if (result < 0) {
- callback->Run(DEMUXER_ERROR_COULD_NOT_PARSE);
+ callback.Run(DEMUXER_ERROR_COULD_NOT_PARSE);
return;
}
@@ -497,7 +496,7 @@ void FFmpegDemuxer::InitializeTask(DataSource* data_source,
}
}
if (no_supported_streams) {
- callback->Run(DEMUXER_ERROR_NO_SUPPORTED_STREAMS);
+ callback.Run(DEMUXER_ERROR_NO_SUPPORTED_STREAMS);
return;
}
if (format_context_->duration != static_cast<int64_t>(AV_NOPTS_VALUE)) {
@@ -523,7 +522,7 @@ void FFmpegDemuxer::InitializeTask(DataSource* data_source,
if (host())
host()->SetDuration(max_duration);
max_duration_ = max_duration;
- callback->Run(PIPELINE_OK);
+ callback.Run(PIPELINE_OK);
}
void FFmpegDemuxer::SeekTask(base::TimeDelta time, const FilterStatusCB& cb) {
« no previous file with comments | « media/filters/ffmpeg_demuxer.h ('k') | media/filters/ffmpeg_demuxer_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698