Issue 7346017: Clean up users of a deprecated base::LaunchApp API.

Issue 7346017: Clean up users of a deprecated base::LaunchApp API. (Closed)

Created:
9 years, 5 months ago by Evan Martin

Modified:
9 years, 5 months ago

Reviewers:
jam, Randy Smith (Not in Mondays), Mark Mentovai, Zachary Kuznia, Paweł Hajdan Jr., Yusuke Sato

CC:
chromium-reviews, cbentzel+watch_chromium.org, kkania, brettw-cc_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Clean up users of a deprecated base::LaunchApp API. BUG=88990 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92393

Patch Set 2 : extra comments #

Patch Set 3 : cros #

Total comments: 2

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -73 lines)			Patch
M	base/process_util.h	View	1	1 chunk	+0 lines, -11 lines	0 comments	Download
M	base/test/multiprocess_test.h	View	1 2	3 chunks	+7 lines, -9 lines	0 comments	Download
M	base/test/multiprocess_test.cc	View	1 2	3 chunks	+9 lines, -23 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_manager.cc	View	1 2	1 chunk	+4 lines, -5 lines	1 comment	Download
M	chrome/browser/chromeos/input_method/xkeyboard.cc	View	1 2	1 chunk	+4 lines, -5 lines	1 comment	Download
M	chrome/browser/mac/relauncher.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/printing/printer_manager_dialog_linux.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/process_info_snapshot_mac_unittest.cc	View	1 2	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/shell_integration_linux.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options/advanced_options_utils_gtk.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/test/automation/proxy_launcher.cc	View		2 chunks	+7 lines, -5 lines	0 comments	Download
M	content/browser/zygote_host_linux.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	net/test/test_server_posix.cc	View		1 chunk	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM http://codereview.chromium.org/7346017/diff/1/base/test/multiprocess_test.h File base/test/multiprocess_test.h (right): http://codereview.chromium.org/7346017/diff/1/base/test/multiprocess_test.h#newcode73 base/test/multiprocess_test.h:73: const file_handle_mapping_vector& fds_to_map, This argument is still unused ...

9 years, 5 months ago (2011-07-12 20:45:00 UTC) #2

Evan Martin

http://codereview.chromium.org/7346017/diff/1/base/test/multiprocess_test.h File base/test/multiprocess_test.h (right): http://codereview.chromium.org/7346017/diff/1/base/test/multiprocess_test.h#newcode73 base/test/multiprocess_test.h:73: const file_handle_mapping_vector& fds_to_map, On 2011/07/12 20:45:00, Mark Mentovai wrote: ...

9 years, 5 months ago (2011-07-12 21:22:29 UTC) #3

Zachary Kuznia

On 2011/07/12 21:57:58, Evan Martin wrote: > +yusuke,zork for chromeos LGTM

9 years, 5 months ago (2011-07-13 00:01:42 UTC) #6

Yusuke Sato

9 years, 5 months ago (2011-07-13 01:50:35 UTC) #8

LGTM

http://codereview.chromium.org/7346017/diff/6001/chrome/browser/chromeos/inpu...
File chrome/browser/chromeos/input_method/input_method_manager.cc (right):

http://codereview.chromium.org/7346017/diff/6001/chrome/browser/chromeos/inpu...
chrome/browser/chromeos/input_method/input_method_manager.cc:760:
base::file_handle_mapping_vector fds_to_remap;
nit: I guess you can remove this line.

http://codereview.chromium.org/7346017/diff/6001/chrome/browser/chromeos/inpu...
File chrome/browser/chromeos/input_method/xkeyboard.cc (right):

http://codereview.chromium.org/7346017/diff/6001/chrome/browser/chromeos/inpu...
chrome/browser/chromeos/input_method/xkeyboard.cc:281:
base::file_handle_mapping_vector fds_to_remap;
ditto

Expand Messages | Collapse Messages