| Index: base/test/multiprocess_test.h
|
| diff --git a/base/test/multiprocess_test.h b/base/test/multiprocess_test.h
|
| index af7a18033655bce2432d14f2d07a045131be1090..bfb9e2ac142d472d1db23eb53417b3f3b13a3290 100644
|
| --- a/base/test/multiprocess_test.h
|
| +++ b/base/test/multiprocess_test.h
|
| @@ -1,4 +1,4 @@
|
| -// Copyright (c) 2010 The Chromium Authors. All rights reserved.
|
| +// Copyright (c) 2011 The Chromium Authors. All rights reserved.
|
| // Use of this source code is governed by a BSD-style license that can be
|
| // found in the LICENSE file.
|
|
|
| @@ -58,6 +58,9 @@ class MultiProcessTest : public PlatformTest {
|
| ProcessHandle SpawnChild(const std::string& procname, bool debug_on_start);
|
|
|
| #if defined(OS_POSIX)
|
| + // TODO(evan): see if we can delete this via more refactoring.
|
| + // SpawnChild() should just take a base::LaunchOptions so that we don't
|
| + // need multiple versions of it.
|
| ProcessHandle SpawnChild(const std::string& procname,
|
| const file_handle_mapping_vector& fds_to_map,
|
| bool debug_on_start);
|
| @@ -68,17 +71,12 @@ class MultiProcessTest : public PlatformTest {
|
| bool debug_on_start);
|
|
|
| private:
|
| -#if defined(OS_WIN)
|
| - ProcessHandle SpawnChildImpl(const std::string& procname,
|
| - bool debug_on_start);
|
| -
|
| -#elif defined(OS_POSIX)
|
| - // TODO(port): with the CommandLine refactoring, this code is very similar
|
| - // to the Windows code. Investigate whether this can be made shorter.
|
| + // Shared implementation of SpawnChild.
|
| + // TODO: |fds_to_map| is unused on Windows; see above TODO about
|
| + // further refactoring.
|
| ProcessHandle SpawnChildImpl(const std::string& procname,
|
| const file_handle_mapping_vector& fds_to_map,
|
| bool debug_on_start);
|
| -#endif
|
|
|
| DISALLOW_COPY_AND_ASSIGN(MultiProcessTest);
|
| };
|
|
|