Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: chrome/browser/chromeos/input_method/xkeyboard.cc

Issue 7346017: Clean up users of a deprecated base::LaunchApp API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cros Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/xkeyboard.cc
diff --git a/chrome/browser/chromeos/input_method/xkeyboard.cc b/chrome/browser/chromeos/input_method/xkeyboard.cc
index 270672d82b367680285fbf4e589d51a84e25c007..7a0b85637f70d34579231f0d2fd38dfbed9c3f56 100644
--- a/chrome/browser/chromeos/input_method/xkeyboard.cc
+++ b/chrome/browser/chromeos/input_method/xkeyboard.cc
@@ -285,11 +285,10 @@ class XKeyboard {
argv.push_back("-layout");
argv.push_back(layout_to_set);
argv.push_back("-synch");
- const bool result = base::LaunchApp(argv,
- fds_to_remap, // No remapping.
- false, // Don't wait.
- &handle);
- if (!result) {
+
+ base::LaunchOptions options;
+ options.process_handle = &handle;
+ if (!base::LaunchProcess(argv, options)) {
LOG(ERROR) << "Failed to execute setxkbmap: " << layout_to_set;
execute_queue_ = std::queue<std::string>(); // clear the queue.
return;

Powered by Google App Engine
This is Rietveld 408576698