Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Unified Diff: chrome/browser/ui/webui/options/advanced_options_utils_gtk.cc

Issue 7346017: Clean up users of a deprecated base::LaunchApp API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cros Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/advanced_options_utils_gtk.cc
diff --git a/chrome/browser/ui/webui/options/advanced_options_utils_gtk.cc b/chrome/browser/ui/webui/options/advanced_options_utils_gtk.cc
index b55454d94ec03f4c9a68e34ecec8b109f6b62f1f..6f267a6e10d2f2d55dd1dcf5a604878d71fa8b33 100644
--- a/chrome/browser/ui/webui/options/advanced_options_utils_gtk.cc
+++ b/chrome/browser/ui/webui/options/advanced_options_utils_gtk.cc
@@ -74,9 +74,10 @@ bool StartProxyConfigUtil(TabContents* tab_contents, const char* command[]) {
std::vector<std::string> argv;
for (size_t i = 0; command[i]; ++i)
argv.push_back(command[i]);
- base::file_handle_mapping_vector no_files;
base::ProcessHandle handle;
- if (!base::LaunchApp(argv, no_files, false, &handle)) {
+ base::LaunchOptions options;
+ options.process_handle = &handle;
+ if (!base::LaunchProcess(argv, options)) {
LOG(ERROR) << "StartProxyConfigUtil failed to start " << command[0];
return false;
}

Powered by Google App Engine
This is Rietveld 408576698