Issue 7249003: Move GetVersionStringModifier() and GetChannel() from platform_util_* to chrome_version_info_*

Issue 7249003: Move GetVersionStringModifier() and GetChannel() from platform_util_* to chrome_version_info_* (Closed)

Created:
9 years, 6 months ago by haraken1

Modified:
9 years, 6 months ago

Reviewers:
akalin, Denis Lagno, tony, Andrew T Wilson (Slow), Rick Campbell, commit-bot: I haz the power, Raghu Simha, Nicolas Zea, tim (not reviewing), lipalani1

CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, Paweł Hajdan Jr., kkania, brettw-cc_chromium.org, tim (not reviewing)

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Move GetVersionStringModifier() and GetChannel() from platform_util_* to chrome_version_info_* BUG=37186 TEST=No behavior change. Manually confirm that build succeeds on Linux, Mac and Windows if we comment out '#if defined(GOOGLE_CHROME_BUILD)' in chrome_version_info_*. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90394

Patch Set 1 : Move GetVersionStringModifier() and GetChannel() from platform_util_* to chrome_version_info.cc #

Total comments: 8

Patch Set 2 : correct nits #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+262 lines, -220 lines)			Patch
M	chrome/app/chrome_main.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/automation/automation_provider.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/browser_about_handler.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/browser_main.cc	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/diagnostics/recon_diagnostics.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/mac/keystone_glue.mm	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/platform_util.h	View		2 chunks	+0 lines, -27 lines	0 comments	Download
M	chrome/browser/platform_util_common_linux.cc	View		1 chunk	+0 lines, -41 lines	0 comments	Download
M	chrome/browser/platform_util_mac.mm	View		2 chunks	+3 lines, -47 lines	0 comments	Download
M	chrome/browser/platform_util_win.cc	View		2 chunks	+0 lines, -46 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/about_window_controller.mm	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/first_run_dialog.mm	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/about_chrome_dialog.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/views/about_chrome_view.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/flash_ui.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/gpu_internals_ui.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/net_internals_ui.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options/about_page_handler.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/upgrade_detector_impl.cc	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/web_resource/promo_resource_service.h	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/web_resource/promo_resource_service.cc	View		5 chunks	+10 lines, -10 lines	0 comments	Download
M	chrome/browser/web_resource/promo_resource_service_unittest.cc	View		5 chunks	+9 lines, -5 lines	0 comments	Download
M	chrome/chrome_common.gypi	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_version_info.h	View		2 chunks	+30 lines, -3 lines	0 comments	Download
A	chrome/common/chrome_version_info_linux.cc	View		1 chunk	+50 lines, -0 lines	0 comments	Download
A	chrome/common/chrome_version_info_mac.mm	View	1	1 chunk	+62 lines, -0 lines	0 comments	Download
A	chrome/common/chrome_version_info_win.cc	View	1	1 chunk	+60 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

haraken1

This is the patch that supports issue 7104106 (http://codereview.chromium.org/7104106/). I just moved GetVersionStringModifier() and GetChannel() ...

9 years, 6 months ago (2011-06-23 14:11:43 UTC) #1

tony

Great! LGTM! http://codereview.chromium.org/7249003/diff/2029/chrome/chrome_common.gypi File chrome/chrome_common.gypi (right): http://codereview.chromium.org/7249003/diff/2029/chrome/chrome_common.gypi#newcode43 chrome/chrome_common.gypi:43: 'common/chrome_version_info_mac.mm', Nit: sort alphabetically http://codereview.chromium.org/7249003/diff/2029/chrome/common/chrome_version_info_mac.mm File chrome/common/chrome_version_info_mac.mm ...

9 years, 6 months ago (2011-06-23 16:54:54 UTC) #2

haraken1

http://codereview.chromium.org/7249003/diff/2029/chrome/chrome_common.gypi File chrome/chrome_common.gypi (right): http://codereview.chromium.org/7249003/diff/2029/chrome/chrome_common.gypi#newcode43 chrome/chrome_common.gypi:43: 'common/chrome_version_info_mac.mm', On 2011/06/23 16:54:54, tony wrote: > Nit: sort ...

9 years, 6 months ago (2011-06-23 23:57:14 UTC) #3

commit-bot: I haz the power

Presubmit check for 7249003-6001 failed and returned exit status 1. Running presubmit commit checks ...

9 years, 6 months ago (2011-06-24 00:25:29 UTC) #4

haraken1

+tim tim: Would you please take a look at chrome/browser/sync/profile_sync_service.cc?

9 years, 6 months ago (2011-06-24 00:46:11 UTC) #5

Change committed as 90394

Expand Messages | Collapse Messages