chrome/browser/browser_about_handler.cc - Issue 7249003: Move GetVersionStringModifier() and GetChannel() from platform_util_* to chrome_version_info_*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_about_handler.cc

Issue 7249003: Move GetVersionStringModifier() and GetChannel() from platform_util_* to chrome_version_info_* (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: correct nits Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/browser_about_handler.cc

diff --git a/chrome/browser/browser_about_handler.cc b/chrome/browser/browser_about_handler.cc

index cd86b8b46c7903a16990b22c702306b419a98fb1..2d40dd44e8cc5e4c0209d87215e8848c2b9acf9f 100644

--- a/chrome/browser/browser_about_handler.cc

+++ b/chrome/browser/browser_about_handler.cc

@@ -32,7 +32,6 @@

#include "chrome/browser/metrics/histogram_synchronizer.h"

#include "chrome/browser/net/predictor_api.h"

#include "chrome/browser/net/url_fixer_upper.h"

-#include "chrome/browser/platform_util.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/profiles/profile_manager.h"

#include "chrome/browser/ui/browser_dialogs.h"

@@ -988,7 +987,7 @@ std::string AboutVersion(DictionaryValue* localized_strings, Profile* profile) {

// this thread.

base::ThreadRestrictions::ScopedAllowIO allow_io;

localized_strings->SetString("version_modifier",

- platform_util::GetVersionStringModifier());

+ chrome::VersionInfo::GetVersionStringModifier());

localized_strings->SetString("os_name",

l10n_util::GetStringUTF16(IDS_ABOUT_VERSION_OS));

localized_strings->SetString("os_type", version_info.OSType());

« no previous file with comments | « chrome/browser/automation/automation_provider.cc ('k') | chrome/browser/browser_main.cc » ('j') | no next file with comments »